qemu.mk: use xterm instead of gnome-terminal #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any "Tested-by: ..." Jerome? |
|
@jbech-linaro well that's tested by me, but I would think this T-b would be implicit here? |
|
jforissier
force-pushed
the
qemu-xterm
branch
from
0731185
to
3d3a128
Compare
|
Tags applied. |
This fixes the issue I originally reported. |
- Make sure launch-terminal cannot block by adding a '&' - Use xterm instead of gnome-terminal because it is more likely to be installed by default. Fixes OP-TEE#18. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Joakim Bech <joakim.bech@linaro.org> Reviewed-by: Pascal Brand <pascal.brand@linaro.org> Tested-by: Pascal Brand <pascal.brand@linaro.org> Reported-by: Peter Maydell <peter.maydell@linaro.org> Tested-by: Peter Maydell <peter.maydell@linaro.org>
jforissier
force-pushed
the
qemu-xterm
branch
from
3d3a128
to
e5425ff
Compare
|
Updated -- thanks Peter. I have also added your Reported-by:, for the record ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installed by default.
Fixes #18.
Signed-off-by: Jerome Forissier jerome.forissier@linaro.org