-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'make run' for QEMU config hangs after starting the first terminal window #18
Comments
Hi Peter, thanks for reporting this. |
This is Ubuntu trusty.
|
Ah, it turns out that if you already have one gnome-terminal running, then running 'gnome-terminal' from the command line will start a new window (presumably by talking to the other process) and then return to the command line. But if this 'gnome-terminal' is the first one, then it does not background itself or return to the command line until all the windows have closed. I guess that you use gnome-terminal as your standard terminal, so it works for you. I use xterm, so the gnome-terminal started by this makefile is typically the only one running. |
It might make sense to replace gnome-terminal in all scripts with xterm as xterm seems to be installed by default on majority of distros (haven't seen one that would not have it yet), while gnome-terminal is only installed by default when distro is gnome based or gnome DE has been installed. |
I've never seen this problem myself, but indeed, I use gnome-terminal as my standard terminal. @ototo , I'm fine with updating to use Also, it might be worth trying to spawn the users standard terminal instead of trying to force a certain terminal. What about using:
Or is the |
@ototo IMO xterm is a bit old-fashioned 😉 but you may have a point. FWIW, the following works fine on my laptop:
|
Yes, x-terminal-emulator is an Ubuntu/Debian-ism. If you want to be fancy you could borrow the (public domain) wrapper script i3-sensible-terminal from i3wm (https://github.com/i3/i3/blob/next/i3-sensible-terminal), which basically does:
But this is probably veering into over-engineering and just using xterm would do fine :-) |
And one more bit: to make xterm looking better I'm using the following ~/XTerm file:
|
What? Everyone knows that xterm has white background and black foreground. ;-) |
- Make sure launch-terminal cannot block by adding a '&' - Use xterm instead of gnome-terminal because it is more likely to be installed by default. Fixes OP-TEE#18. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
- Make sure launch-terminal cannot block by adding a '&' - Use xterm instead of gnome-terminal because it is more likely to be installed by default. Fixes OP-TEE#18. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Joakim Bech <joakim.bech@linaro.org> Reviewed-by: Pascal Brand <pascal.brand@linaro.org> Tested-by: Pascal Brand <pascal.brand@linaro.org>
- Make sure launch-terminal cannot block by adding a '&' - Use xterm instead of gnome-terminal because it is more likely to be installed by default. Fixes OP-TEE#18. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Joakim Bech <joakim.bech@linaro.org> Reviewed-by: Pascal Brand <pascal.brand@linaro.org> Tested-by: Pascal Brand <pascal.brand@linaro.org> Reported-by: Peter Maydell <peter.maydell@linaro.org> Tested-by: Peter Maydell <peter.maydell@linaro.org>
If I do a 'make run' (or 'make run-only') for the QEMU config, following the instructions in https://github.com/OP-TEE/optee_os, then this hangs after starting the first terminal window.
This seems to be because the makefile process does (more or less)
gnome_terminal
gnome_terminal
qemu
and since the gnome_terminal execution isn't backgrounded then we never continue past starting the first terminal window. Adding an '&' to the definiton of the launch-terminal function fixes this for me:
The text was updated successfully, but these errors were encountered: