xtest: regression_1037: Close attestation session #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host/xtest/regression_1000.c
Outdated
| @@ -3141,6 +3141,8 @@ static void xtest_tee_test_1037(ADBG_Case_t *c) | |||
| Do_ADBG_EndSubCase(c, "TA attestation (memory)"); | |||
|
|
|||
| free_att_key(); | |||
|
|
|||
| TEEC_CloseSession(&session); | |||
There was a problem hiding this comment.
Good catch. I wonder if it wouldn't make sense to put this just after the if (... above since it's not by anything past that point.
There was a problem hiding this comment.
Good catch. I wonder if it wouldn't make sense to put this just after the
if (...above since it's not by anything past that point.
Hi @jenswi-linaro, do you mean to put TEEC_CloseSession directly on line 3126?
There was a problem hiding this comment.
do you mean to put TEEC_CloseSession directly on line 3126?
Yes
There was a problem hiding this comment.
do you mean to put TEEC_CloseSession directly on line 3126?
Yes
OK, the new modification is submited, please review, thanks.
Signed-off-by: chenchaokai <chenchaokai@eswincomputing.com> Reviewed-by: liushiwei <liushiwei@eswincomputing.com> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed-by: liushiwei liushiwei@eswincomputing.com