-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source term and property stabilization #28
Conversation
…od and added support for second-order time discretization for the backward (BDF2) scheme. also cleaned up thermophysical properties update to be consistent with Gauss harmonic corrected laplacian scheme
When generating these plots are you comparing to an analytical solution or to something generated using the solver at very fine dt? If the latter, I would guess that the deviation from 2nd order accuracy (which appears to be caused by the finest time step value) might be caused at least in part by the error in the reference solution becoming non-negligible compared to the error in the solution at that point |
My reference solution is using BDF2 with a time step of ~1e-8s. This approach is necessary when an analytical solution does not exist. If the solution convergence is monotonic, then I believe that the order of accuracy of the method can be determined from the log(change in error)/log(change in time step) as the time step is halved. Our solutions are not strictly second order, which may be due to setting the source term to the implicit time. We can try averaging this term over time steps, but this may require some special logic when the beam turns on/off. |
added stabilization to the latent heat source term linearization method and added support for second-order time discretization for the backward (BDF2) scheme. also cleaned up thermophysical properties update to be consistent with Gauss harmonic corrected laplacian scheme.
The near second order converge of the solver using the backward scheme is demonstrated