Fix: os2forms_forloeb: Maestro notification attempts sending digital post that will never be delivered #195
Description
Problem
Digital post, SF1601, requires that recipientID is digits and is either 8 or 10 of them, depending on whether it is a CVR- or CPR-number. As of right now, this is described on page 19 of "SF1601 Postkomponent - KombiPostAfsend - Feltbeskrivelse" found in their compressed documentation package.
Consequently, dashes are not allowed in CPR-numbers.
Handling in digital post handler
This is unintentionally handled during the processing of jobs from the normal Digital Post handler by removing all non-digits which had the intention of helping detecting whether we were dealing with CVR or CPR.
Missing handling in Maestro notification handler
It is not (intentionally or unintentionally) handled during the processing of Maestro notifications jobs. This means that instances where maestro notifications have been sent to 'dashed' CPR-numbers will have never been received despite the submission log claiming it as being sent.
Interestingly, according to Kombit, these would have been sent as 'Fjern print' instead.
Note
As long as we do not use Beskedfordeleren, we have no way of knowing whether digital post has been delivered or not. We can however limit the scenarios in which we know digital post will never be received by removing non-digits as in the Digital Post handler case.