Skip to content

Release 3.15.8 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Release 3.15.8 #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e290c61
Correctly created MaestroNotificationHandler
jekuaitk Aug 21, 2024
d7b5b2a
Updated CHANGELOG
jekuaitk Aug 21, 2024
49c6551
Cleaned up object creation
rimi-itk Aug 21, 2024
4fe719d
Merge pull request #128 from itk-dev/feature/cleanup
rimi-itk Aug 21, 2024
7b986df
Updated CHANGELOG
jekuaitk Aug 26, 2024
227a486
Merge pull request #127 from OS2Forms/fix/parent-create
jekuaitk Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ before starting to add changes. Use example [placed in the end of the page](#exa

## [Unreleased]

## [3.15.8] 2024-08-26

- [#127](https://github.com/OS2Forms/os2forms/pull/127)
Correctly created MaestroNotificationHandler

## [3.15.7] 2024-08-15

- [#123](https://github.com/OS2Forms/os2forms/pull/123)
Expand Down Expand Up @@ -257,7 +262,8 @@ before starting to add changes. Use example [placed in the end of the page](#exa
- Security in case of vulnerabilities.
```

[Unreleased]: https://github.com/OS2Forms/os2forms/compare/3.15.7...HEAD
[Unreleased]: https://github.com/OS2Forms/os2forms/compare/3.15.8...HEAD
[3.15.8]: https://github.com/OS2Forms/os2forms/compare/3.15.7...3.15.8
[3.15.7]: https://github.com/OS2Forms/os2forms/compare/3.15.6...3.15.7
[3.15.6]: https://github.com/OS2Forms/os2forms/compare/3.15.5...3.15.6
[3.15.5]: https://github.com/OS2Forms/os2forms/compare/3.15.4...3.15.5
Expand Down
12 changes: 2 additions & 10 deletions modules/os2forms_digital_post/src/Plugin/WebformHandler/WebformHandlerSF1601.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,9 @@ final class WebformHandlerSF1601 extends WebformHandlerBase {
* @phpstan-param array<string, mixed> $configuration
*/
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
$instance = new static($configuration, $plugin_id, $plugin_definition);

$instance->loggerFactory = $container->get('logger.factory');
$instance->configFactory = $container->get('config.factory');
$instance->renderer = $container->get('renderer');
$instance->entityTypeManager = $container->get('entity_type.manager');
$instance->conditionsValidator = $container->get('webform_submission.conditions_validator');
$instance->tokenManager = $container->get('webform.token_manager');
$instance->helper = $container->get(WebformHelperSF1601::class);
$instance = parent::create($container, $configuration, $plugin_id, $plugin_definition);

$instance->setConfiguration($configuration);
$instance->helper = $container->get(WebformHelperSF1601::class);

return $instance;
}
Expand Down
18 changes: 0 additions & 18 deletions modules/os2forms_forloeb/src/Plugin/WebformHandler/MaestroNotificationHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
use Drupal\Core\Link;
use Drupal\os2forms_forloeb\MaestroHelper;
use Drupal\webform\Plugin\WebformHandlerBase;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
* Maestro notification handler.
Expand Down Expand Up @@ -45,23 +44,6 @@ final class MaestroNotificationHandler extends WebformHandlerBase {
*/
private const NOTIFICATION_SUBJECT_MAX_LENGTH = 128;

/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
$instance = new static($configuration, $plugin_id, $plugin_definition);

$instance->loggerFactory = $container->get('logger.factory');
$instance->configFactory = $container->get('config.factory');
$instance->renderer = $container->get('renderer');
$instance->entityTypeManager = $container->get('entity_type.manager');
$instance->conditionsValidator = $container->get('webform_submission.conditions_validator');

$instance->setConfiguration($configuration);

return $instance;
}

/**
* {@inheritdoc}
*/
Expand Down