Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobComposer: Custom, user defined template sources #183

Open
Tracked by #3394
ericfranz opened this issue Apr 14, 2016 · 1 comment
Open
Tracked by #3394

JobComposer: Custom, user defined template sources #183

ericfranz opened this issue Apr 14, 2016 · 1 comment
Labels
component/jobcomposer enhancement This is functionality that builds upon existing functionality.
Milestone

Comments

@ericfranz
Copy link
Contributor

ericfranz commented Apr 14, 2016

A template source is a directory whose subdirectories are job templates.

Currently there are two template sources: OSC Templates and My Templates. Alongside these fixed locations to find templates, let the user add extra paths to new template sources.

CustomSource and Source would share functionality. Ideally CustomSource would be a type of Source but also be ActiveRecord - so we would need to put some thought into the implementation to make this clean. The list of all templates would be extended to include Source.my.templates + Source.osc.templates + CustomSource.all.map(&templates) (pseudocode)

This would involve five UI changes:

  1. Add /sources/new to create a new template source:

jobconstructor!UNITO-UNDERSCORE!sources!UNITO-UNDERSCORE!new

2.Add /sources/edit to edit a template source (that is not OSC or My Templates - ignore the fact that this screenshot shows editing that - it would actually only allow you to edit custom template sources):

jobconstructor!UNITO-UNDERSCORE!sources!UNITO-UNDERSCORE!edit

  1. Source dropdown would be added to the new job page with the options for adding or editing template sources added to this. Source dropdown would have (and default) to "All) showing all templates (as new job page currently does) or allow you to select a specific template source to view that. The edit button would be enabled if you select a custom template source. The add button would always be there:

jobconstructor!UNITO-UNDERSCORE!templates

Unfortunately, this would involve a schema change.

┆Issue is synchronized with this Asana task by Unito

@MorganRodgers MorganRodgers changed the title Custom, user defined template sources JobComposer: Custom, user defined template sources Nov 12, 2019
@MorganRodgers MorganRodgers transferred this issue from OSC/ood-myjobs Nov 12, 2019
@ericfranz ericfranz added this to the Backlog milestone Jan 30, 2020
treydock pushed a commit to treydock/ondemand that referenced this issue Dec 24, 2020
Render Time Used as hours:minutes:seconds in the client using Moment.js
@lukew3 lukew3 added the enhancement This is functionality that builds upon existing functionality. label Jun 27, 2022
@johrstrom
Copy link
Contributor

This applies to the current job composer - so a lot of the notes aren't as relevant to the project manager. That said - the core of the idea is good and so we should keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/jobcomposer enhancement This is functionality that builds upon existing functionality.
Projects
Status: Reviewed, Not Scheduled
Development

No branches or pull requests

4 participants