lookForGridInfo(): make it work properly when passed the old PROJ name #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis/QGIS#45470 That is, if the file for the old PROJ name is not found, but the file for the new PROJ name is found, then use the later for fullFilename and gridAvailable.
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Jan 20, 2022
…g PROJ < 7 grid names (fixes qgis#45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Jan 20, 2022
…g PROJ < 7 grid names (fixes qgis#45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
rouault
added a commit
to rouault/QGIS
that referenced
this pull request
Jan 20, 2022
…g PROJ < 7 grid names (fixes qgis#45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
2 tasks
nyalldawson
approved these changes
Jan 20, 2022
|
I'm curious -- how does this differ from #1944 ? Or did that fix regress? |
Ah, got it. Thanks! |
nyalldawson
pushed a commit
to qgis/QGIS
that referenced
this pull request
Jan 23, 2022
…g PROJ < 7 grid names (fixes #45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
qgis-bot
pushed a commit
to qgis/QGIS
that referenced
this pull request
Jan 23, 2022
…g PROJ < 7 grid names (fixes #45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
nyalldawson
pushed a commit
to qgis/QGIS
that referenced
this pull request
Jan 24, 2022
…g PROJ < 7 grid names (fixes #45470) Only use proj_coordoperation_is_instantiable() if PROJ networking is enabled. The reason is that proj_coordoperation_is_instantiable() in PROJ < 9.0 does not work properly when a coordinate operation refers to a PROJ < 7 grid name (gtx/gsb) but the user has installed PROJ >= 7 GeoTIFF grids. Cf OSGeo/PROJ#3025. When networking is not enabled, proj_create() will check that all grids are present, so proj_coordoperation_is_instantiable() is not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes qgis/QGIS#45470
That is, if the file for the old PROJ name is not found, but the file
for the new PROJ name is found, then use the later for fullFilename and
gridAvailable.