Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON/WKT: avoid precision issues on non-Intel architectures on coordinate epochs (fixes #3632) #3633

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

rouault
Copy link
Member

@rouault rouault commented Feb 22, 2023

@sebastic does it help?

@sebastic
Copy link
Contributor

Thanks for the quick action.

Unfortunately the tests still fail the same way with the changes from this PR, see:

https://buildd.debian.org/status/package.php?p=proj&suite=experimental

@rouault
Copy link
Member Author

rouault commented Feb 22, 2023

Unfortunately the tests still fail the same way with the changes from this PR, see:

hum, weird. Oh well I've added 7b0af47 that should hopefully avoid the issue...

@sebastic
Copy link
Contributor

Build now succeeded on armel, armhf, and mipsel, but still failed on mips64el:

55: ./test/unit/gie_self_tests.cpp:1238: Failure
55: The difference between output_over_normalized.xyz.x and -24490287.974520184 is nan, which exceeds 1e-8, where
55: output_over_normalized.xyz.x evaluates to nan,
55: -24490287.974520184 evaluates to -24490287.974520184, and
55: 1e-8 evaluates to 1e-08.
55: [  FAILED  ] gie.proj_create_crs_to_crs_from_pj_force_over (557 ms)

@rouault
Copy link
Member Author

rouault commented Feb 23, 2023

@sebastic Perhaps fa8f46c will help for the mips64el failure ?

@sebastic
Copy link
Contributor

Thanks, the build now also succeeded on mips64el:

https://buildd.debian.org/status/package.php?p=proj&suite=experimental

@rouault rouault merged commit b302ae7 into OSGeo:master Feb 23, 2023
github-actions bot pushed a commit that referenced this pull request Feb 23, 2023
JSON/WKT: avoid precision issues on non-Intel architectures on coordinate epochs (fixes #3632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants