Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis to use proj-datumgrid-1.7. #822

Merged
merged 4 commits into from
Mar 5, 2018

Conversation

sebastic
Copy link
Contributor

No need to download BETA2007.gsb separately any more.

@kbevers
Copy link
Member

kbevers commented Feb 23, 2018

I disagree. The package is 100+ MB. It is just a waste of time and bandwith to download that. That is one of the reasons why I want to create subdivisions of the datumgrids package.

@sebastic
Copy link
Contributor Author

Then the grids that are considered "too big" should be removed from proj-datumgrid.

@kbevers
Copy link
Member

kbevers commented Feb 24, 2018

I understand where you are coming from and in principle I agree. The thing is though, there's a difference between users that download the package once and an automated system downloading the package several of a hundred times a day (there's 15 test targets that all need the package, that's ~1.5GB pr commit). It takes extra time to download the package, but more importantly it wastes bandwith for both OSGeo and the CI providers. We get all of this for free and I don't want to abuse that privilige unless it is necessary. It isn't in this case. So for now i prefer to download what's needed for the tests to run and not much else.

I believe it should be possible to do caching of frequently downloaded files. When I have some more time on my hands I will look into that as a part of a more thorough overhaul of the test-suite.

@sebastic sebastic changed the title Update travis to use proj-datumgrid-1.7RC1. Update travis to use proj-datumgrid-1.7RC2. Feb 26, 2018
@sebastic
Copy link
Contributor Author

proj-datumgrid-1.7RC2 is of much more reasonable size (only slightly more than double the 1.6 size).

Both the Travis & AppVeyor configuration were updated to use it.

@kbevers
Copy link
Member

kbevers commented Mar 5, 2018

@sebastic Do you mind updating this to use the final 1.7 package?

@sebastic sebastic changed the title Update travis to use proj-datumgrid-1.7RC2. Update travis to use proj-datumgrid-1.7. Mar 5, 2018
@sebastic
Copy link
Contributor Author

sebastic commented Mar 5, 2018

Do you mind updating this to use the final 1.7 package?

Done in 9738867

@kbevers kbevers merged commit 7d9a545 into OSGeo:master Mar 5, 2018
@kbevers
Copy link
Member

kbevers commented Mar 5, 2018

Thanks!

@sebastic sebastic deleted the travis-proj-datumgrid branch March 5, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants