Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: fix disable tests flag when building proj for the Windows build #10657

Conversation

stoneLeaf
Copy link
Contributor

@stoneLeaf stoneLeaf commented Aug 27, 2024

What does this PR do?

The GitHub Action for the Windows release builds the PROJ dependency from source.
The flag passed to disable building its testing tree was renamed and thus no longer working.

The flag was renamed with PROJ version 7.0, and the version used for the build is 9.3.

Properly disabling the testing tree building speeds up the PROJ build.

References:

What are related issues/pull requests?

N/A

Tasklist

  • All CI builds and checks have passed

@rouault rouault merged commit c09fd95 into OSGeo:master Aug 27, 2024
32 checks passed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.352% (-0.003%) from 69.355%
when pulling 5aa26ee on stoneLeaf:disable-tests-when-building-proj-in-windows-github-action
into 449d5f0 on OSGeo:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants