netCDF driver: simplify identification logic by just checking runtime availability of HDF4/HDF5 drivers #10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwehr
reviewed
Sep 6, 2024
| #endif | ||
| #ifdef HAVE_HDF5 | ||
| poDriver->SetMetadataItem("GDAL_HAS_HDF5", "YES"); | ||
| #endif |
There was a problem hiding this comment.
Wondering if there is anything counting on these being there or absent.
There was a problem hiding this comment.
not in GDAL at least: https://github.com/search?q=repo%3AOSGeo%2Fgdal%20GDAL_HAS_HDF5&type=code
and not in any Debian source code : https://codesearch.debian.net/search?q=GDAL_HAS_HDF5
There was a problem hiding this comment.
For completness, adding this in the commit message
"Also remove the GDAL_HAS_HDF4 and GDAL_HAS_HDF5 metadata items
from the metadata of the netCDF driver. They are redundant with checking
for GDALGetDriverByName("HDF4" / "HDF5") != nullptr."
… availability of HDF4/HDF5 drivers...
... ignoring their compile-time availability, which makes it more
robust in the case of plugin-only builds.
Also remove the GDAL_HAS_HDF4 and GDAL_HAS_HDF5 metadata items
from the metadata of the netCDF driver. They are redundant with checking
for GDALGetDriverByName("HDF4" / "HDF5") != nullptr.
rouault
force-pushed
the
netcdf_identify_hdf4_hdf5
branch
from
a58f124
to
e78d91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... ignoring their compile-time availability, which makes it more robust in the case of plugin-only builds.
Also remove the GDAL_HAS_HDF4 and GDAL_HAS_HDF5 metadata items from the metadata of the netCDF driver. They are redundant with checking for GDALGetDriverByName("HDF4" / "HDF5") != nullptr.
CC @schwehr