NetCDF-4 groups support on reading #1180
Conversation
|
The only failing Travis CI check (https://travis-ci.org/OSGeo/gdal/jobs/476739965) seems related to recent NGW commits which broke NGW autotests. |
|
You might want to squash all commits in a single one (perhaps except 461fc8b), once you're done. |
jdemaria
force-pushed
the
netcdf4-groups-support
branch
from
06937f2
to
38fdb70
Compare
Ok I have fixed all points you raised, and squashed commits but I'm not sure if it's ok because I see commits from masters in the list? It seems checks failure are still only related to recent NGW commits which broke NGW autotests (test_ogr_ngw_14). |
|
Hum, you didn't squash correctly. Looks like some merge instead, but with original commits modified... There are some hints there to squash: https://github.com/OSGeo/gdal/blob/master/CONTRIBUTING.md |
- Explore recursively all nested groups to create the subdatasets list - Subdatasets in nested groups use the /group1/group2/.../groupn/var standard NetCDF-4 convention, except for variables in the root group which do not have a leading slash for backward compatibility with the NetCDF-3 driver - Global attributes of each nested group are also collected in the GDAL dataset metadata, using the same convention /group1/group2/.../groupn/NC_GLOBAL#attr_name, except for the root group which do not have a leading slash for backward compatibility - When searching for a variable containing auxiliary information on the selected subdataset, like coordinate variables or grid_mapping, we now also search in parent groups and their childs as specified in cf-convention/cf-conventions#144
jdemaria
force-pushed
the
netcdf4-groups-support
branch
from
38fdb70
to
2a574c4
Compare
|
Ok sorry however I tried to follow these hints but surely did something wrong... |
What does this PR do?
NetCDF-4 groups support on reading
What are related issues/pull requests?
Tasklist
Environment
Provide environment details, if relevant: