Strip TOWGS84 when datum is known, in GTiff, Spatialite and GPKG drivers #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses qgis/QGIS#34993 Implements a simplified version of the idea mentioned in https://lists.osgeo.org/pipermail/gdal-dev/2020-March/051881.html with a variant of the more radical approach suggested in https://lists.osgeo.org/pipermail/gdal-dev/2020-March/051885.html That is the new method OGRSpatialReference::StripTOWGS84IfKnownDatumAndAllowed() will remove TOWGS84 information from SRS whose datum name is known, unless the OSR_STRIP_TOWGS84 configuration option is set to NO. When TOWGS84 information is striped, a debug message is emitted.
|
I'll test today, but just wanted to say that the logic looks good to me (and makes sense to me). Thanks for the fix! |
|
Tested and confirmed working as desired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses qgis/QGIS#34993
Implements a simplified version of the idea mentioned in
https://lists.osgeo.org/pipermail/gdal-dev/2020-March/051881.html
with a variant of the more radical approach suggested in
https://lists.osgeo.org/pipermail/gdal-dev/2020-March/051885.html
That is the new method OGRSpatialReference::StripTOWGS84IfKnownDatumAndAllowed()
will remove TOWGS84 information from SRS whose datum name is known,
unless the OSR_STRIP_TOWGS84 configuration option is set to NO.
When TOWGS84 information is striped, a debug message is emitted.