Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add esri bundle cache driver #2663

Merged
merged 21 commits into from
Jun 13, 2020
Merged

Add esri bundle cache driver #2663

merged 21 commits into from
Jun 13, 2020

Conversation

lucianpls
Copy link
Contributor

@lucianpls lucianpls commented Jun 10, 2020 •
edited
Loading

Read only

What does this PR do?

Add a raster driver, read Esri bundle cache as a single raster

What are related issues/pull requests?

Tasklist

  • ADD YOUR TASKS HERE
  • Add test case(s)
  • Add documentation
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS:
  • Compiler:

@rouault
Copy link
Member

rouault commented Jun 10, 2020 

esric_dataset.cpp(55): warning C4189: 'v': local variable is initialized but not referenced

rouault
rouault requested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need tests and documentation (in doc/source/drivers/raster/)

gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Show resolved Hide resolved
gdal/frmts/esric/GNUmakefile Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
@lucianpls
Copy link
Contributor Author

lucianpls commented Jun 11, 2020 •
edited
Loading

Yes, I will add documentation and test.

rouault
rouault reviewed Jun 11, 2020
View reviewed changes
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
gdal/frmts/esric/esric_dataset.cpp Outdated Show resolved Hide resolved
rouault
rouault reviewed Jun 11, 2020
View reviewed changes
autotest/gdrivers/esric.py Outdated Show resolved Hide resolved
autotest/gdrivers/esric.py Outdated Show resolved Hide resolved
@lucianpls
Copy link
Contributor Author

All issues were resolved, can we merge this?

Thanks!

@rouault rouault merged commit 59c3234 into OSGeo:master Jun 13, 2020
@lucianpls lucianpls deleted the esric branch January 14, 2021 18:05
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jratike80 jratike80 jratike80 left review comments

@rouault rouault rouault requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucianpls @rouault @jratike80