Add support for field aliases to OGRFieldDefn, read alias in openfilegdb driver #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
requested changes
Jun 30, 2020
|
I would have voted for "AlternativeName". I have also use cases in my mind when I probably would not rename fields by expanding but rather by using more compact names (INSPIRE schemas, database tables named after company wide naming conventions etc). |
|
All comments addressed |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting/retrieving field aliases to OGRFieldDefn. It also adds support for reading the embedded field alias information stored in .gdb tables (with the openfilegdb driver at least -- would likely be possible with the filegdb driver too, but i distinctly lack motivation to work on that one!).
It's possible other formats also have native alias support which would benefit from this, but I'm not personally aware of any...!