Remove ODBC text trimming behaviour #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Digging into history shows that the whitespace trimming is as old as the initial implementation: 39c4d2b#diff-22bf0bc3c1e2c8216ba95373356aaac4667ce29e46b067d14f7e64adf494540eR389 |
|
Once this passes CI, I am going to merge. If something breaks we can always put it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the white space trimming from the ODBC fetching code which removes spaces from ODBC text field on retrieval.
The behaviour makes it difficult to use ODBC results for some use cases that consider white space important, and was discovered here pramsey/pgsql-ogr-fdw#208
Either the behaviour should be removed, or made conditional on a run-time option. A compile-time option seems not worth the effort. Initial PR for CI tests, and then can use this PR for final commit or run-time option implementation.