Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python package installation in custom prefixes #65

Closed
wants to merge 8 commits into from
Closed

Fix python package installation in custom prefixes #65

wants to merge 8 commits into from

Conversation

avalentino
Copy link
Member

This PR should address issue no 4563: "Python bindings installation ignores prefix"

@rouault
Copy link
Member

rouault commented Aug 20, 2015

This breaks "sudo make install" on Travis. See https://travis-ci.org/OSGeo/gdal/builds/76490525

@avalentino
Copy link
Member Author

@rouault OK, it seems to work now

@rouault
Copy link
Member

rouault commented Aug 22, 2015

Hum, specifying this INSTALL_LAYOUT=deb is kind of annoying at make install time. I've never seen that before. Any chance this could be auto-defined by swig/python/GNUmakefile ?

@avalentino
Copy link
Member Author

Hum, specifying this INSTALL_LAYOUT=deb is kind of annoying at make install time. I've never seen that before.

--install-layout is a setup.py option that allows to install python packages in the directories used by debian based systems (basically dist-packages instead of site-packages).

Any chance this could be auto-defined by swig/python/GNUmakefile ?

Yes, I think that I can find a way to deduce default system layout in the GNUmakefile

@rouault
Copy link
Member

rouault commented Sep 19, 2015

@avalentino Any progress on autodetecting debian layout ?

@avalentino
Copy link
Member Author

@rouault it should be OK now

@rouault
Copy link
Member

rouault commented Sep 19, 2015

Oh sorry, I didn't see the later commits. Oh and as you're a committer, I let you apply.

rouault pushed a commit that referenced this pull request Sep 20, 2015
@avalentino
Fix python package installation in custom prefixes (Closes: #4563, gh-65
105b94f 
)

Squashed commit of the following:

commit c6b0917e27d1c006be56bc44b21a28d0cbca15a7
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Wed Aug 26 13:09:48 2015 +0200

    Remove debugging statement

commit babecb94cc355698d0cca78fe2b962049eda7090
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Sat Aug 22 11:43:47 2015 +0200

    Drop INSTALL_LAYOUT setting from travis configuration file

commit a6e0bfb8523fdd8c0f6cfbbbc578aed7666c4ebb
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Sat Aug 22 11:40:52 2015 +0200

    Automatically detect the default system layout for python packages

commit cf2a0e1582237f6b7e16f0427167cb2a46c56526
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Fri Aug 21 11:38:37 2015 +0200

    Fix env setting in .travis.yml

commit 6becb4812335e71ae0d21abc73f3e7a80d332faf
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Fri Aug 21 11:06:15 2015 +0200

    Only specify --install-layout if it is deb

commit b46d477d6f4f02d3d85dc5d57ad2390f6f0e7d7d
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Fri Aug 21 10:53:35 2015 +0200

    Use deb installation layput for python bindings on travis

commit 1e26b27798a88c75c261702b88eec41dec299a94
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Fri Aug 21 10:52:36 2015 +0200

    Better control of python installation layout

commit 6cd1fda554952978afa992817759e1a3f85cfc5c
Author: Antonio Valentino <antonio.valentino@tiscali.it>
Date:   Wed Aug 19 19:17:46 2015 +0200

    Fix python package installation in custom prefixes

git-svn-id: https://svn.osgeo.org/gdal/trunk@30564 f0d54148-0727-0410-94bb-9a71ac55c965
@avalentino
Copy link
Member Author

Merged with commit 105b94f (svn r30564)

@avalentino avalentino closed this Sep 20, 2015
@avalentino avalentino deleted the python_install branch September 20, 2015 08:56
@avalentino avalentino mentioned this pull request Sep 20, 2015
Closed
@rouault rouault mentioned this pull request Apr 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avalentino @rouault