Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: tweak alpine configuration to use numpy 2.0.0rc1 #9752

Closed
wants to merge 1 commit into from

Conversation

rouault
Copy link
Member

@rouault rouault commented Apr 24, 2024

Refs #9751

This commit should be reverted once alpine:edge switches to numpy 2 as it disables pyarrow related tests (however the alpine 32 bit config still has it)

@jakirkham
Copy link

Thanks Even! 🙏

FWIW Arrow 16.0.0 should have NumPy 2 compatibility

Refs:

@coveralls
Copy link
Collaborator

coveralls commented Apr 25, 2024

Coverage Status

coverage: 69.063% (+0.001%) from 69.062%
when pulling 5691d4d on rouault:ci_numpy_2
into bfe3946 on OSGeo:master.

@rouault
Copy link
Member Author

rouault commented Apr 25, 2024

@dbaston Maybe you have some ideas of what might happen . In https://github.com/OSGeo/gdal/actions/runs/8824768156/job/24227829652?pr=9752 , I got a weird failure during test execution where pyarrow import worked (but was broken, probably because it relies on numpy 1 whereas this PR installs numpy2), despite I removed it from being installed in the Dockerfile.ci by this pull request. It seems like there was some remain of it from a previous Docker image where it was installed.

@rouault rouault force-pushed the ci_numpy_2 branch 3 times, most recently from a8954af to 2225b30 Compare April 25, 2024 01:46
Refs OSGeo#9751

This commit should be reverted once alpine:edge switches to numpy 2
as it disables pyarrow related tests (however the alpine 32 bit config
still has it)
@rouault
Copy link
Member Author

rouault commented Apr 25, 2024

@dbaston Please ignore my above comment. Nothing caching related. The issue is actually solved with:

# apache-arrow-dev actually comes with an embedded pyarrow version, which is not py3-pyarrow, and is non functional !
RUN mv /usr/lib/python3.12/site-packages/pyarrow /usr/lib/python3.12/site-packages/pyarrow.disabled

@rouault
Copy link
Member Author

rouault commented Apr 25, 2024

closing that one as superseded per #9753

@rouault rouault closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants