Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trac #3818 (bug in modules.xml: double man1 in path), possibly #93

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 20, 2020

This might fix #3818. I can't test this fix, but reviewing the code behind https://grass.osgeo.org/addons/grass7/modules.xml and comparing with similar code in g.extension.py:1317 make me believe this can be the cause of the problem.

The modules.xml is generated along addon compilation on server, with log file inluding this double-man1 directory, see eg. https://grass.osgeo.org/addons/grass7/logs/db.join.log:

...
mkdir -p /tmp/.grass7/addons/db.join/docs/html
mkdir -p /tmp/.grass7/addons/db.join/docs/man/man1
mkdir -p /tmp/.grass7/addons/db.join/docs/man/man1/man1
mkdir -p /tmp/.grass7/addons/db.join/scripts
...
VERSION_NUMBER=7.8.3dev /work/src/grass78/dist.x86_64-pc-linux-gnu/tools/g.html2man.py \
"/tmp/.grass7/addons/db.join/docs/html/db.join.html" \ 
"/tmp/.grass7/addons/db.join/docs/man/man1/man1/db.join.1"
...

@neteler neteler requested a review from landam March 17, 2020 17:17
@neteler neteler changed the title Fix trac #3818, possibly Fix trac #3818 (bug in modules.xml: double man1 in path), possibly Mar 18, 2020
@landam landam added the bug Something isn't working label Mar 19, 2020
@landam landam merged commit aaf3b3a into OSGeo:master Mar 19, 2020
landam pushed a commit to landam/grass-addons that referenced this pull request Dec 10, 2020
@nilason nilason deleted the fix-trac-3818 branch July 8, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants