Add License Header #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added license header to all files
mrrosen
changed the title
|
Should add it to software-controller.ino in the main directory as well. Also, it would be better if you added new lines in the header so the lines arent so long, at 80/100 char is typical |
|
Ok. Will make the changes
…On Mon, Aug 31, 2020 at 2:44 PM Rosen, Michael R ***@***.***> wrote:
Should add it to software-controller.ino in the main directory as well.
Also, it would be better if you added new lines in the header so the lines
arent so long, at 80/100 char is typical
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJPO5ERAOFOZMPF3NTOUSK3SDQKSTANCNFSM4QQ65KNA>
.
|
This reverts commit 766a34e. redo based on Mike's review #
|
Done and committed,
…On Mon, Aug 31, 2020 at 2:47 PM Lakshman ***@***.***> wrote:
Ok. Will make the changes
On Mon, Aug 31, 2020 at 2:44 PM Rosen, Michael R ***@***.***>
wrote:
>
>
> Should add it to software-controller.ino in the main directory as well.
>
>
> Also, it would be better if you added new lines in the header so the
> lines arent so long, at 80/100 char is typical
>
>
>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#67 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJPO5ERAOFOZMPF3NTOUSK3SDQKSTANCNFSM4QQ65KNA>
> .
>
>
>
|
|
Looks good, been added since its just really one commit (the top one), I just added that commit to develop so this is done now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added license header to all files