Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 Cryptography - requirement for Encrypted Client Hello (ECH) #2358

Closed
danielcuthbert opened this issue Nov 8, 2024 · 14 comments
Closed

V6 Cryptography - requirement for Encrypted Client Hello (ECH) #2358

danielcuthbert opened this issue Nov 8, 2024 · 14 comments
Assignees
Labels
5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR V9 _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@danielcuthbert
Copy link
Collaborator

Encrypted Client Hello (ECH) pertains to TLS and its goal to protect metadata by encrypting client-sent data like the Server Name Indication (SNI) that might otherwise leak potentially sensitive information.

V6.8 In-Use Data Cryptography broadly addresses data protection during use and during transmission, this would be a suitable section to add a requirement for ECH

more on ECH can be found on the amazing Cloudflare blog https://blog.cloudflare.com/announcing-encrypted-client-hello/

As such, it's a huge privacy tool and I am proposing we add it to V6

| 6.8.3 | [ADDED] Verify that Encrypted Client Hello (ECH) is supported and properly configured within the application’s TLS settings to prevent exposure of sensitive metadata, such as the Server Name Indication (SNI), during TLS handshake processes. | | ✓ | ✓ | |

@danielcuthbert danielcuthbert added 4) proposal for review Issue contains clear proposal for add/change something _5.0 - prep This needs to be addressed to prepare 5.0 V6 labels Nov 8, 2024
@danielcuthbert danielcuthbert self-assigned this Nov 8, 2024
danielcuthbert added a commit that referenced this issue Nov 8, 2024
@tghosth
Copy link
Collaborator

tghosth commented Nov 8, 2024

Does it fit better into V9 with other TLS stuff?

@tghosth
Copy link
Collaborator

tghosth commented Nov 8, 2024

@danielcuthbert ?

@danielcuthbert
Copy link
Collaborator Author

You know I did ponder this and im torn. Yes and no. But then should TLS be in crypto? It could fit in 9.1 nicely but that is looking a bit bare too.

@jmanico
Copy link
Member

jmanico commented Nov 8, 2024 via email

@randomstuff
Copy link
Contributor

randomstuff commented Nov 8, 2024

ECH is really great/important for privacy but I am wondering whether it is really for prime time as it is not yet RFC status. And whether we should require it for now or if this should just be a recommendation.

@jmanico
Copy link
Member

jmanico commented Nov 8, 2024 via email

@danielcuthbert
Copy link
Collaborator Author

@randomstuff one can argue that when Cloudflare has deployed it, for me that's massive scale primetime right? you couldn't get more of a huge platform to iron out the bugs

@elarlang
Copy link
Collaborator

elarlang commented Nov 9, 2024

I'm not technically competent to comment the topic but...

ECH is really great/important for privacy but I am wondering whether it is really for prime time as it is not yet RFC status. And whether we should require it for now or if this should just be a recommendation.

For OAuth/OIDC we use not released drafts, we aligned many requirements from NIST not released drafts, so it is more question does it make sense as a security requirement - that is general enough, has the impact and is not too niche.

@danielcuthbert
Copy link
Collaborator Author

All valid questions @elarlang ill report back with outcomes.
@jmanico what other cryptography elements do you feel 5.0 is missing?

@tghosth
Copy link
Collaborator

tghosth commented Nov 10, 2024

(I am going to mark PR as draft and wait to see what else @danielcuthbert finds and also result of discussion between @jmanico and @danielcuthbert )

@jmanico
Copy link
Member

jmanico commented Nov 10, 2024

All valid questions @elarlang ill report back with outcomes. @jmanico what other cryptography elements do you feel 5.0 is missing?

I added separate issues for a few things in v6!

@tghosth
Copy link
Collaborator

tghosth commented Nov 11, 2024

All valid questions @elarlang ill report back with outcomes. @jmanico what other cryptography elements do you feel 5.0 is missing?

I added separate issues for a few things in v6!

Where did you add those @jmanico ?

@randomstuff
Copy link
Contributor

randomstuff commented Nov 13, 2024

@tghosth

Does it fit better into V9 with other TLS stuff?

The V6 chapter is now called "Stored Cryptogtaphy" and not "Cryptogtaphy". Do we want that? There are things here (such as random values) which are applicable in many different contexts (such as access tokens) which don't really fall into the "stored crypography".

ECH would definitely fit into V9 however.

@tghosth
Copy link
Collaborator

tghosth commented Nov 18, 2024

Having read through this a little more and also looking at the discussion on what should go into which chapter, I think this is more related to TLS/secure communications rather than pure cryptography. I think you could argue it both ways but for that reason plus the fact that TLS is mostly discussed in V9, I think it is better in V9.

I also agree that it is important enough to be specifically included although I would argue that maybe it should be L3.

@danielcuthbert would you mind closing #2359 and opening a new PR to add it as 9.4.4.

@tghosth tghosth added 5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR V9 and removed 4) proposal for review Issue contains clear proposal for add/change something V6 labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5) awaiting PR A proposal hs been accepted and reviewed and we are now waiting for a PR V9 _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

No branches or pull requests

5 participants