Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last login feature implemented #87

Closed
wants to merge 5 commits into from
Closed

Last login feature implemented #87

wants to merge 5 commits into from

Conversation

mebjas
Copy link
Member

@mebjas mebjas commented Feb 23, 2014

I guess I found why the test was failing!
Here is code to implement last login features so that LAST_LOGIN in db will be updated when ever user log's In

For maintaining last login feature
The **test was failing because** while checking for testCheckIfTempPassExpired() **time() was being set incorrectly**
@mebjas
Copy link
Member Author

mebjas commented Feb 23, 2014

@SvenRtbg the test was failing because in the test environment in test/libs/auth/AdvPasswordTest.php the time() was being set to a hard-coded value which was causing the assertion to fail.
I'd like to know if I need to make further modifications in LAST LOGIN implementation @abiusx

@mebjas mebjas mentioned this pull request Feb 23, 2014
@abhshkdz
Copy link
Contributor

abhshkdz commented Jun 9, 2014

@mebjas I don't think this was ever merged. And now the last_login branch on mebjas/phpsec doesn't seem to exist. Could you have a look once?

@mebjas
Copy link
Member Author

mebjas commented Jun 9, 2014

I have sent a new one!

@mebjas mebjas closed this Jun 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants