The 'jf::CurrentUser()' method does not exist

[jburns131]

The 'jf::CurrentUser()' method does not exist, causing errors:

• $rbac->Users->HasRole() // Complete
• $rbac->Users->Assign() // Complete
• $rbac->Users->Unassign() // Complete
• $rbac->Users->AllRoles() // Complete
• $rbac->Users->RoleCount() // Complete
• $rbac->Users->Enforce() // Complete

All of the above throw PHP errors if no '$User/$UserID' parameter is provided ($User/$UserID = null). The proper behavior is to check 'jf::CurrentUser()' for current user id, but if 'jf::CurrentUser()' does not exist we get an error stating that fact.

I'm assuming that 'CurrentUser' is an interface that users of PhpRbac needs to implement, but wanted to verify that.

I was wondering if it might be a good idea to implement CurrentUser() with a default of 0 (zero, for guest), and either allow the user of PhpRbac to override it, or have a setter so users can dynamically update the current UserID.

I've added the following code to the jf class (jf.php) as a temporary fix so I can continue working on Unit Tests:

static function CurrentUser() {
    return 0; // Guest
}

[abiusx]

it is a means of retriving the current (logged in) user ID to check for permissions, cuz its the most common case.
it is left there to be implemented by the developer, but marking it out in a PSR implementatin woul dbe a good idea. Its authentication domain and should not be included in authorization.
-A

---

Notice: This message is digitally signed, its source and integrity are verifiable.
If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mordad 31, 1392, at 1:48 AM, Jesse Burns notifications@github.com wrote:

The 'jf::CurrentUser()' method does not exist, causing errors:

$rbac->Users->HasRole()
$rbac->Users->Assign()
$rbac->Users->Unassign()
$rbac->Users->AllRoles()
$rbac->Users->RoleCount()
$rbac->Users->Enforce()
All of the above throw PHP errors if no '$User/$UserID' parameter is provided ($User/$UserID = null). The proper behavior is to check 'jf::CurrentUser()' for current user id, but if 'jf::CurrentUser()' does not exist we get an error stating that fact.

I'm assuming that 'CurrentUser' is an interface that users of PhpRbac needs to implement, but wanted to verify that.

I was wondering if it might be a good idea to implement CurrentUser() with a default of 0 (zero, for guest), and either allow the user of PhpRbac to override it, or have a setter so users can dynamically update the current UserID.

I've added the following code to the jf class (jb.php) as a temporary fix so I can continue working on Unit Tests:

static function CurrentUser() {
return 0;
}
—
Reply to this email directly or view it on GitHub.

[jburns131]

Thank you. If it's ok with you I will remove any reference to jf::Current user, thus making the user-id mandatory.

I will also update the above mentioned methods and create/throw an exception if the user-id argument is empty.

Sound good?

[abiusx]

gr8

---

Notice: This message is digitally signed, its source and integrity are verifiable.
If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Shahrivar 1, 1392, at 7:20 AM, Jesse Burns notifications@github.com wrote:

Thank you. If it's ok with you I will remove any reference to jf::Current user, thus making the user-id mandatory.

I will also update the above mentioned methods and create/throw an exception if the user-id argument is empty.

Sound good?

—
Reply to this email directly or view it on GitHub.

[jburns131]

I've addressed this Issue in commit aebafee

Please review and close Issue if everything looks good to you.