Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore : Adding missing components of compile_rust.yaml #35

Merged
merged 22 commits into from
Sep 29, 2023

Conversation

puneeth072003
Copy link
Contributor

@puneeth072003 puneeth072003 commented Jul 17, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Completing the workflows

  • Cplus
  • go
  • rust

@puneeth072003
Copy link
Contributor Author

puneeth072003 commented Jul 18, 2023

Sorry all links should have been #19

My bad😉

@puneeth072003
Copy link
Contributor Author

RUST workflow Completed

  • Rust

@puneeth072003 puneeth072003 marked this pull request as ready for review July 18, 2023 02:59
@commjoen
Copy link
Collaborator

can we make sure that, instead off the full target folder, we offer the executable only for download?

@puneeth072003
Copy link
Contributor Author

puneeth072003 commented Aug 6, 2023

can we make sure that, instead off the full target folder, we offer the executable only for download?

Hmm...I'll try that and let you know

@puneeth072003
Copy link
Contributor Author

@commjoen Let me know the changes are ok or not
if they are then i'll implement the same for other jobs and workflows.

@puneeth072003
Copy link
Contributor Author

@commjoen i fixed it
please look at executable-C-linux-x64 and confirm
Screenshot 2023-09-20 094856

@puneeth072003
Copy link
Contributor Author

is it ok?

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @puneeth072003 ! this fixes a lot of stuff!

@commjoen commjoen merged commit e3af4f0 into OWASP:main Sep 29, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants