Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Github actions #714

Open
6 tasks
commjoen opened this issue Mar 20, 2023 · 9 comments
Open
6 tasks

Optimize Github actions #714

commjoen opened this issue Mar 20, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@commjoen
Copy link
Collaborator

commjoen commented Mar 20, 2023

In order to become more efficient in CLI time there are a bunch of things we can simplify:

  • 1. create 1 clean-install with all the sskips in place materials to have the jar file
  • 2. Change swagger action to depend on 1
  • 3. Change DAST to depend on 1
  • 4. Change Docker container creation action to depend on1
  • Optimize many of the github actions to just run once instead of twice during a PR.
  • quickfail container test if something is wrong...
@RemakingEden
Copy link
Collaborator

Ive noticed the docker container Github action check does not immediately fail when something goes wrong. It hangs until the timeout has been exceeded. I think this will be using a lot of your Github minutes as the timeout is 6 hours.

Might be good to add that to the fix
image

@commjoen commjoen added the enhancement New feature or request label May 14, 2023
@puneeth072003
Copy link
Contributor

@commjoen I'm really interested in working on this.
Please give me this incredible opportunity.

@commjoen
Copy link
Collaborator Author

commjoen commented May 26, 2023

It is all yours ;-)

@RemakingEden
Copy link
Collaborator

RemakingEden commented May 29, 2023

So ive got a couple of other ideas of how to clean up the pipelines a little. @commjoen @puneeth072003 let me know if I should start another ticket or we should add to this one.

  1. Clean up test workflow output. Right now as we are running everything through maven we get a lot of output based on the build and running. I find it can be a little tricky to figure out the debug message you are actually looking for. I either think simplified output from maven or perhaps a test report that is exported with each run.

  2. Consistent naming conventions and a workflow file for each distinct piece e.g. a test workflow file and a security workflow file. The only problems I can forsee with this is that you can't move artifacts between each workflow file so if you want workflows to depend on each other it is tricky.

@commjoen
Copy link
Collaborator Author

Good to do that in this issue :-)

@puneeth072003
Copy link
Contributor

@RemakingEden Great suggestions!! Happy to implement those

@commjoen
Copy link
Collaborator Author

Will be picked up after OWASP/wrongsecrets-binaries#35 :) .

@puneeth072003
Copy link
Contributor

I'll start by task 3

  • Change DAST to depend on 1

@puneeth072003
Copy link
Contributor

@commjoen happy to continue with the issue

puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 27, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 30, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 30, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 30, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 30, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 30, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this issue Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants