Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty articleList, articleList will not be null but an empty Arti… #6

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

ivoba
Copy link
Collaborator

@ivoba ivoba commented Mar 14, 2019

fix empty articleList, articleList will not be null but an empty ArticleList

This bug allows writing any tag url to the SeoUrls table.
We found a lot of hack attempts as URLs int he SeoUrls table.
Like: tag/coolproduct1111111111111-union-select-char-45-120-49-45-81-45/order-by-as-oxid/
@kermie i think this an urgent fix

@kermie kermie merged commit 24d2094 into OXIDprojects:master Mar 14, 2019
@ivoba
Copy link
Collaborator Author

ivoba commented Mar 18, 2019

@kermie thx for merging.
Shall we update the Changelog and tag a new release: v2.0.2

@kermie
Copy link
Contributor

kermie commented Mar 18, 2019

@ivoba sure. Could you note the changes to changelog as PR? I am going to merge it immediately and tag the new version. After that, we should think about making you admin to this repo, shouldn't we? ^^

@ivoba ivoba deleted the fix-empty-articlelist branch March 19, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants