-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeRTOS CMake file update #202
Conversation
robamu
commented
Jun 6, 2021
- Added more warnings if paths are not found
- Added new path suffixes because of changed FreeRTOS kernel structure
1. Added more warnings if paths are not found 2. Added new path suffixes because of changed FreeRTOS kernel structure
Unfortunately it looks like this is no longer being maintained. I have a few more changes as well... If you are willing to maintain a fork maybe we could merge it all... |
I'm not sure whether it is not maintained anymore or it just takes a long time.. In any case, the fastest solution probably would be to have a fork for now.. I already forked the project for my personal account, but I could fork the project for my own organization (which allows to me add people as well), merge your PRs and then merge my own PRs. What do you think? |
Sounds good to me... |
Sounds good, that would be nice. If the repository is transferred to an organization (free one is okay as well), you can also assign more people to be able to merge pull requests. If all PRs I require are merged, I will definitely switch back to the upstream again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor format remark. Appart from that it seems OK.
Done Co-authored-by: Julien Staub <atsju2@yahoo.fr>
Done Co-authored-by: Julien Staub <atsju2@yahoo.fr>
…spacefish/stm32-cmake into mueller/cmake-freertos-update
cmake/FindFreeRTOS.cmake
Outdated
NO_DEFAULT_PATH | ||
) | ||
|
||
if(FreeRTOS_COMMON_INCLUDE MATCHES "FreeRTOS_COMMON_INCLUDE-NOTFOUND") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the same coding style what about :
if(FreeRTOS_COMMON_INCLUDE MATCHES "FreeRTOS_COMMON_INCLUDE-NOTFOUND") | |
if(NOT FreeRTOS_COMMON_INCLUDE) |
"portable/GCC/${PORT}/r0p1" | ||
"portable/GCC/${PORT}" | ||
"Source/portable/GCC/${PORT}" | ||
"Source/portable/GCC/${PORT}/r0p1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alphabetical order
"portable/GCC/${PORT}/r0p1" | |
"portable/GCC/${PORT}" | |
"Source/portable/GCC/${PORT}" | |
"Source/portable/GCC/${PORT}/r0p1" | |
"portable/GCC/${PORT}" | |
"portable/GCC/${PORT}/r0p1" | |
"Source/portable/GCC/${PORT}" | |
"Source/portable/GCC/${PORT}/r0p1" |
cmake/FindFreeRTOS.cmake
Outdated
NO_DEFAULT_PATH | ||
) | ||
|
||
if(FreeRTOS_${PORT}_PATH MATCHES "FreeRTOS_${PORT}_PATH-NOTFOUND") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(FreeRTOS_${PORT}_PATH MATCHES "FreeRTOS_${PORT}_PATH-NOTFOUND") | |
if(NOT FreeRTOS_${PORT}_PATH) |