-
Notifications
You must be signed in to change notification settings - Fork 9
Add download scripts to ooipy #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hey @anishdixit-uw, would you mind testing out this script and see if it works for you? |
for more information, see https://pre-commit.ci
I think the unit tests are failing because we need to add xarray as a dependancy |
Okay @John-Ragland , I'll try running the script locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had to install the tqdm library but the download works properly following the instructions to run download_hydrophone_data.py.
Okay, I can add tqdm to the required packages. And after figuring out why pre-commit is failing, this will be ready to merge. |
@John-Ragland I figured the issue with pre-commit, it fails for flake8, which is just a styling check. If you replace line 124: With this block of code:
It should now pass |
for more information, see https://pre-commit.ci
Added your code block. I had thought that the pre-commit stuff fixed the styling automatically. For now I can just fix this line manually like you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passed
🎉 |
I'm going to go ahead and create this PR and we can update it as we add more functionality