Skip to content

Conversation

anishdixit-uw
Copy link
Collaborator

Don's process added in using pip install -e ooipy.

@anishdixit-uw
Copy link
Collaborator Author

@John-Ragland , this is ready to merge

@John-Ragland
Copy link
Member

Closes #155

@John-Ragland
Copy link
Member

Closes #154

@lsetiawan
Copy link
Collaborator

I don't see a step to install the dev requirements... should there be one?

@anishdixit-uw
Copy link
Collaborator Author

I don't see a step to install the dev requirements... should there be one?

@lsetiawan I am unsure about this, I thought pip install -e ooipy would install those too.

If i am wrong, are you aware of what command would install the dev requirements? Would a pip install -r dev_requirements.txt work?

@John-Ragland
Copy link
Member

I don't see a step to install the dev requirements... should there be one?

@lsetiawan I am unsure about this, I thought pip install -e ooipy would install those too.

If i am wrong, are you aware of what command would install the dev requirements? Would a pip install -r dev_requirements.txt work?

Yeah, pip install -r dev-requirements.txt should work. I think that we will eventually use the features of hatch and the optional install stuff (which I still don't fully understand). But for this PR we should be good to just use this command.

@lsetiawan
Copy link
Collaborator

Ditto. Also, the extra dependencies are not only specific to hatch. It can also be used with setuptools which is your current build frontend. It's simply just a way to install packages in addition to your default packages. This way say you have a listing for 'development' packages, you can then install by doing 'pip install -e "ooipy[development]"'. This tells pip to install packages for development as well. Without specifying the brackets, it's installing the minimal requirement. Makes sense?

@anishdixit-uw
Copy link
Collaborator Author

Thanks @lsetiawan , that helps!

1. develop OOIPY -> install OOIPY

2. init.py -> __init__.py

3. dev-requirements.txt installation added in.
@anishdixit-uw
Copy link
Collaborator Author

@John-Ragland , made all the changes, plz check and merge if it seems good!

@John-Ragland John-Ragland merged commit 46f23fa into 116_prerelease Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants