Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Delete Validation on issue #291 & #45 , Adding Tooltip Capability in Field Configuration (Enhancement) #364

Closed
wants to merge 5 commits into from
Closed

Fix Delete Validation on issue #291 & #45 , Adding Tooltip Capability in Field Configuration (Enhancement) #364

wants to merge 5 commits into from

Conversation

ViktorIwan
Copy link
Contributor

@ViktorIwan ViktorIwan commented Feb 28, 2017 •
edited
Loading

I'm new to git and the whole pull request thing.. wondering why my fixes combine into single pullrequest ?

@ViktorIwan ViktorIwan changed the title Fix Delete Validation on issue #291 Fix Delete Validation on issue #291 , Adding Tooltip Capability in Field Condiguration (Enhancement) Mar 1, 2017
@ViktorIwan ViktorIwan changed the title Fix Delete Validation on issue #291 , Adding Tooltip Capability in Field Condiguration (Enhancement) Fix Delete Validation on issue #291 , Adding Tooltip Capability in Field Configuration (Enhancement) Mar 1, 2017
@ViktorIwan ViktorIwan changed the title Fix Delete Validation on issue #291 , Adding Tooltip Capability in Field Configuration (Enhancement) Fix Delete Validation on issue #291 & #45 , Adding Tooltip Capability in Field Configuration (Enhancement) Mar 1, 2017
@sebastienheraud
Copy link
Member

sebastienheraud commented Jun 19, 2017 •
edited
Loading

Hello Viktor,
Indeed a PR with many unrelated changes is unlikely to be merged.
Here is a quick help about contributions https://github.com/Octopoos/SEBLOD/wiki/How-to-contribute%3F. If it's not clear enough, @klas may be able to help you.
See below 2 fixes, related to one of your changes.
Fix about Free Button: dee4ed4
Fix about Delete Link: 31daefe
Thank you,
Saba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
won't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViktorIwan @sebastienheraud