Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore / Limit grimshot window grab #10

Merged

Conversation

paulodiovani
Copy link
Contributor

Updated PR for swaywm/sway#7158

The grimshot script accepts option to screenshot current output, window or area, but the window option will also allow area shot If the user click and grab the mouse.

This change adds the -r option to slurt, so when using grimshot window it will only possible to select an existing window area.

From slurp -r

  -r           Restrict selection to predefined boxes.

Copy link
Owner

@OctopusET OctopusET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@OctopusET OctopusET merged commit c6f601b into OctopusET:master Aug 24, 2023
@paulodiovani paulodiovani deleted the chore/limit-grimshot-window-grab branch August 24, 2023 14:18
@fluix-dev
Copy link

Can I ask why this is a good idea, especially considering it breaks backwards compatibility? Personally, I use my own script which is equivalent to the new anything option being proposed, but what's wrong with the extra feature that you can click and drag to select a region?

@paulodiovani
Copy link
Contributor Author

Can I ask why this is a good idea, especially considering it breaks backwards compatibility? Personally, I use my own script which is equivalent to the new anything option being proposed, but what's wrong with the extra feature that you can click and drag to select a region?

Without the -r option the user could accidentally drag and take a screenshot of a much smaller area by mistake. It is a small issue, but it can be annoying if trying to screenshot something with movement (a video or log stream, for example).

IMO it does not break backward compatibility because there is still the area option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants