Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest changes 11/21 #247

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Get latest changes 11/21 #247

merged 1 commit into from
Nov 21, 2018

Conversation

ElizabethSamuel-MSFT
Copy link
Contributor

No description provided.

@o365devx
Copy link
Collaborator

✅ Validation status: passed

File Status Preview URL Details
docs/docs-ref-autogen/office/office.activeview.yml ✅Succeeded
docs/docs-ref-autogen/office/office.binding.yml ✅Succeeded
docs/docs-ref-autogen/office/office.bindings.yml ✅Succeeded
docs/docs-ref-autogen/office/office.bindingtype.yml ✅Succeeded
docs/docs-ref-autogen/office/office.coerciontype.yml ✅Succeeded
docs/docs-ref-autogen/office/office.customxmlnode.yml ✅Succeeded
docs/docs-ref-autogen/office/office.customxmlnodetype.yml ✅Succeeded
docs/docs-ref-autogen/office/office.customxmlpart.yml ✅Succeeded
docs/docs-ref-autogen/office/office.customxmlparts.yml ✅Succeeded
docs/docs-ref-autogen/office/office.customxmlprefixmappings.yml ✅Succeeded
docs/docs-ref-autogen/office/office.document.yml ✅Succeeded
docs/docs-ref-autogen/office/office.documentmode.yml ✅Succeeded
docs/docs-ref-autogen/office/office.file.yml ✅Succeeded
docs/docs-ref-autogen/office/office.filetype.yml ✅Succeeded
docs/docs-ref-autogen/office/office.matrixbinding.yml ✅Succeeded
docs/docs-ref-autogen/office/office.nodedeletedeventargs.yml ✅Succeeded
docs/docs-ref-autogen/office/office.nodeinsertedeventargs.yml ✅Succeeded
docs/docs-ref-autogen/office/office.nodereplacedeventargs.yml ✅Succeeded
docs/docs-ref-autogen/office/office.settings.yml ✅Succeeded
docs/docs-ref-autogen/office/office.table.yml ✅Succeeded
docs/docs-ref-autogen/office/office.tablebinding.yml ✅Succeeded
docs/docs-ref-autogen/office/office.textbinding.yml ✅Succeeded
generate-docs/api-extractor-inputs-office/office.d.ts ✅Succeeded
generate-docs/json/office.api.json ✅Succeeded
generate-docs/script-inputs/office.d.ts ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@kbrandl kbrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments (questions).

</td></tr> <tr><td><strong> Excel </strong></td><td> Y </td><td> Y </td><td> Y </td></tr> <tr><td><strong>
PowerPoint </strong></td><td> Y </td><td> Y </td><td> Y </td></tr> <tr><td><strong> Word </strong></td><td> Y
</td><td> Y </td><td> Y </td></tr> </table>
browser) </th><th> Office for iPad </th><th> Office for Mac </th></tr> <tr><td><strong> Access </strong></td><td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the "Supported hosts, by platform" table within the url property section also contain a column for "Office for Mac" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have info for methods from the SOT and not properties so I couldn't verify that. I was able to make a best guess for some of the properties (e.g. the platform for that host supports the entire object or the requirement set and so by extension supports any and all methods and properties) but I couldn't make that determination for this property and others like it.

In DefinitelyTyped, I can certainly add the column but I don't have the details needed to fill it for each host.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. If we don't have the information necessary to confidently populate the additional column, probably best to omit it for now.

(in browser) </th><th> Office for iPad </th></tr> <tr><td><strong> Excel </strong></td><td> </td><td> Y
</td><td> </td></tr> </table>
(in browser) </th><th> Office for iPad </th></tr> <tr><td><strong> Access </strong></td><td> </td><td> Y
</td><td> </td></tr> <tr><td><strong> Excel </strong></td><td> </td><td> Y </td><td> </td></tr> </table>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this table also contain a column for "Office for Mac" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants