Skip to content

Conversation

AlexJerabek
Copy link
Collaborator

Fixes #627.

The old sample relied on a try/catch block to handle a comment missing from the cell. When use of try/catch blocks became no longer recommended in loops, the sample removed that logic without sufficient error checking. The current version of the script will work regardless of pre-existing comments in the sample workbook.

@learn-build-service-prod
Copy link

Learn Build status updates of commit c68fe1c:

✅ Validation status: passed

File Status Preview URL Details
docs/resources/samples/add-excel-comments.md ✅Succeeded View
docs/resources/samples/add-excel-comments.xlsx ✅Succeeded View
docs/resources/samples/excel-comments.xlsx ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 6b663bd:

✅ Validation status: passed

File Status Preview URL Details
docs/resources/samples/add-excel-comments.md ✅Succeeded View
docs/resources/samples/add-excel-comments.xlsx ✅Succeeded View
docs/resources/samples/excel-comments.xlsx ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 2cabdde:

✅ Validation status: passed

File Status Preview URL Details
docs/resources/samples/add-excel-comments.md ✅Succeeded View
docs/resources/samples/add-excel-comments.xlsx ✅Succeeded View
docs/resources/samples/excel-comments.xlsx ✅Succeeded n/a (file deleted or renamed)

For more details, please refer to the build report.

For any questions, please:

@AlexJerabek AlexJerabek merged commit aa37f82 into main Aug 21, 2023
@AlexJerabek AlexJerabek deleted the AlexJ-CommentSample branch August 21, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in the sample
2 participants