fix(env-checker): update to 'Continue anyway' to reduce confusion #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinezh
requested review from
a1exwang,
dooriya,
kimizhu,
kuojianlu,
meifans,
swatDong,
XiaofuHuang and
xiaolang124
as code owners
a1exwang
approved these changes
May 18, 2021
kimizhu
approved these changes
May 18, 2021
LongOddCode
pushed a commit
that referenced
this pull request
May 20, 2021
LongOddCode
pushed a commit
that referenced
this pull request
May 26, 2021
MSFT-yiz
added a commit
that referenced
this pull request
May 26, 2021
* chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.0 - @microsoft/teamsfx-cli@0.1.0-rc.0 - @microsoft/teamsfx-core@0.1.0-rc.0 - @microsoft/teamsfx@0.1.2-rc.0 - teamsfx-extension@2.0.0-rc.0 * fix: unify user cancel handling (#1038) * fix: unify user cancel handling * fix: update sdk test Co-authored-by: Long Hao <haolong@microsoft.com> * docs(sdk): update API Signed-off-by: GitHub Actions <actions@github.com> * chore(core): formating core (#1040) * fix(solution): await setSubscription (#1053) * fix(cli): add support for confirm question with multiple options (#1055) * fix(vsc): format vscode (#1057) * docs: update sample app strings (#1048) * docs: update sample app strings * docs: update cli sample app strings * Update Readme for release branch (#1047) * fix: readmes for bots and msg exts * fix: readmes for messaging extensions * fix: tab readmes * fix: readmes for functions * fix: download sample app to same folder will overwrite (#1060) * fix(env-checker): update the behavior when learn more link clicked (#1059) * fix: no help/issure link (#1065) Co-authored-by: Zhiyu You <zhiyou@microsoft.com> * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.1 - @microsoft/teamsfx-cli@0.1.0-rc.1 - @microsoft/teamsfx-core@0.1.0-rc.1 - @microsoft/teamsfx@0.1.2-rc.1 - teamsfx-extension@2.0.0-rc.1 * fix(local-debug): fix help doc typo (#1067) Teams capacity -> Teams capability * fix(appstudio): publish manual submit async (#1062) * fix: add getting started for cli readme (#1072) * chore: bump simpleauth version to 0.1.0 (#1061) * chore: bump simpleauth version to 0.1.0 * chore: trigger CI for all pull requests * fix: throw error when download samples to the folder twice (#1073) Co-authored-by: Zhiyu You <zhiyou@microsoft.com> * fix(env-checker): fix dotnet-not-installed error message for Linux in function plugin (#1070) * fix(env-checker): fix dotnet not installed error message for Linux in function plugin * chore(env-checker): copy common to extension * fix: fix a typo * fix(env-checker): correct the bookmark within help link (#1071) * fix(spfx): fix spfx cancel bug (#1074) * fix(solution): do not start provision for already provisioned state (#1078) * fix(solution): already provisioned handle * fix: revert lock * Fix: make login telemetry accurate for extension and CLI (#1051) * fix: fix login telemetry * fix: fix login telemetry result * fix: fix extension login telemetry * fix: fix login telemetry for exention and cli * fix: fix unsed const * fix: fix account name for appstudio * fix(vsc): only open preview readme (#1080) * chore: bump version of simple auth bits in simple auth plugin (#1075) * chore: bump version of simple auth bits in simple auth plugin * chore: bump version of simple auth in sdk tests * chore: revert changes to sdk integration test * fix: disable formatting for spfx scaffold template & revert to non-format one (#1082) * fix: remove faq plus sample app in extension sample gallery page (#1081) * fix: remove faq plus app in extension * feat: reorder sample apps in cmd * fix(env-checker): update to 'Continue anyway' to reduce confusion (#1086) * fix: update the order of samples in CLI (#1088) Co-authored-by: Zhiyu You <zhiyou@microsoft.com> * fix(solution): sane default value for developer fields when tab is not activated (#1090) * fix: invalid version and icons (#1089) * fix: update default version for spfx * fix: update icons to meet the requirements * fix(local-debug): use solution setting to get active plugins (#1087) * feat(env-checker): fix missing env checker popup when run f5 from WSL (#1085) * feat: fix missing env checker popup when run f5 from WSL * fix: remove opn in vscode-extension * fix: use await * fix: update package-lock.json * chore: regen lock files Co-authored-by: LongOddCode <haolong@microsoft.com> * fix: add app id to local debug telemetry (#1092) * fix: add app id to local debug telemetry * fix: add local debug app id * fix(vsc): open sample readme (#1093) * fix(vsc): only open preview readme * fix(vsc): open sample readme * fix(vsc): update extension name same as toolkit v1 (#1095) * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.2 - @microsoft/teamsfx-cli@0.1.0-rc.2 - @microsoft/teamsfx-core@0.1.0-rc.2 - @microsoft/teamsfx@0.1.2-rc.2 - ms-teams-vscode-extension@2.0.0-rc.2 * fix: update toolkit survey link (#1096) * fix: update toolkit survey link * fix: remove comments * fix: sample app download images broken (#1094) * fix: sample app download images broken * fix: cLI download samples Co-authored-by: Zhiyu You <zhiyou@microsoft.com> * fix(bot): bot name conflicts (#1098) * fix(bot): add specific error message for bot name conflicts * chore(bot): add log for manually updating message endpoint * chore(bot): refine error design, name, reduce duplicated code * fix: use another method to check the error type (#1101) Co-authored-by: Zhiyu You <zhiyou@microsoft.com> * fix: toast message if user doesn't provision for spfx project before publish (#1105) * fix(core): do not readConfigs in progress of provision (#1103) * fix(core): do not readConfigs in progress of provision * fix(core): await sleep * docs(env-checker): update the notification message of help doc according to the latest changes (#1100) * fix simply auth to simple auth (#1106) Co-authored-by: Junjie Li <junjieli@MILAN-LAP2.fareast.corp.microsoft.com> * Temp readme (#1108) * README Clean Up * Adjust the validate/build order Co-authored-by: Junjie Li <junjieli@MILAN-LAP2.fareast.corp.microsoft.com> * fix: show modal dialog for those that need user action (#1076) * fix: show modal dialog for those that need user action * fix(cli): update cli interface * fix: cli cancel provision not work * fix(spfx): toast message still wait for user input * feat: show error notification if deploy or publish before provision * docs: change to 'pricing calculator' Co-authored-by: Jiayi Ruan <jirua@microsoft.com> Co-authored-by: Zihong Chen <zihch@outlook.com> * feat(solution): update manifest to v1.10 (#1109) * Zhenya/readme5 (#1111) * fix(readmes): remove code of conduct in template folders * fix: support.md * fix: viewport directives for tabS * fix: remove vscode specific telemetry statement * fix: add section describing manifest to all template readmes * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.3 - @microsoft/teamsfx-cli@0.1.0-rc.3 - @microsoft/teamsfx-core@0.1.0-rc.3 - @microsoft/teamsfx@0.1.2-rc.3 - ms-teams-vscode-extension@2.0.0-rc.3 * Add Preview Section In README (#1112) Co-authored-by: Junjie Li <junjieli@MILAN-LAP2.fareast.corp.microsoft.com> * fix(solution): set manifest version to 1.9 (#1114) * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.4 - @microsoft/teamsfx-cli@0.1.0-rc.4 - @microsoft/teamsfx-core@0.1.0-rc.4 - @microsoft/teamsfx@0.1.2-rc.4 - ms-teams-vscode-extension@2.0.0-rc.4 * fix(vsc): update vsc contribution guide (#1116) * fix: update aka link (#1126) * fix: update aka link * fix: update aka link in vsc readme * Fix CLI instructions (#1122) * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0-rc.5 - @microsoft/teamsfx-cli@0.1.0-rc.5 - @microsoft/teamsfx-core@0.1.0-rc.5 - @microsoft/teamsfx@0.1.2-rc.5 - ms-teams-vscode-extension@2.0.0-rc.5 * Update CHANGELOG.md (#1141) recreate PR as collaborator * chore(release): publish detail - @microsoft/teamsfx-api@0.1.0 - @microsoft/teamsfx-cli@0.1.0 - @microsoft/teamsfx-core@0.1.0 - @microsoft/teamsfx@0.1.2 - ms-teams-vscode-extension@2.0.0 * hotfix: skip join view when local debug (#1146) * fix: skip join view when local debug * chore: remove unused comment * chore: update version in changelog for hotfix (#1147) * chore: update version in changelog * chore: revert empty lines change * feat: cd all in one (#1148) * feat: cd all in one * fix: use empty as default value of cd pipeline * feat: add sleep before pack visc * chore(release): publish detail - @microsoft/teamsfx-api@0.1.1 - @microsoft/teamsfx-cli@0.1.1 - @microsoft/teamsfx-core@0.1.1 - @microsoft/teamsfx@0.1.3 - ms-teams-vscode-extension@2.0.1 * feat: add action to publish vsix file to vscode marketplace (#1154) * feat: add action to publish vsix file to vscode marketplace * fix: use wget build-in retry param * fix: sync sdk version Co-authored-by: MSFT-yiz <yiz@microsoft.com> Co-authored-by: Huajie Zhang <zhjay23@qq.com> Co-authored-by: LongOddCode <LongOddCode@users.noreply.github.com> Co-authored-by: WANG YEFU <yefuwang@microsoft.com> Co-authored-by: jiayi-ruan <72644308+jiayi-ruan@users.noreply.github.com> Co-authored-by: Zihong <zihch@outlook.com> Co-authored-by: HuihuiWu-Microsoft <73154171+HuihuiWu-Microsoft@users.noreply.github.com> Co-authored-by: Zhenya <zhenyasav@users.noreply.github.com> Co-authored-by: qinezh <qinezh@users.noreply.github.com> Co-authored-by: Alive-Fish <15262146+Alive-Fish@users.noreply.github.com> Co-authored-by: Zhiyu You <zhiyou@microsoft.com> Co-authored-by: Kuojian Lu <kuojianlu@gmail.com> Co-authored-by: chagong <chagon@microsoft.com> Co-authored-by: Chaoyi Yuan <blackchoey@gmail.com> Co-authored-by: Alex Wang <a1exwang@users.noreply.github.com> Co-authored-by: Ning Liu <71362691+nliu-ms@users.noreply.github.com> Co-authored-by: Meifans Zhao <pengfeizhao@microsoft.com> Co-authored-by: Qianhao Dong <qidon@microsoft.com> Co-authored-by: Ivan Jobs <ivan1377@163.com> Co-authored-by: Junjie Li <jj.muyang@gmail.com> Co-authored-by: Junjie Li <junjieli@MILAN-LAP2.fareast.corp.microsoft.com> Co-authored-by: Jiayi Ruan <jirua@microsoft.com> Co-authored-by: Zhidi Shang <zhshang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work item: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/9951344/
Summary: Update the text of
Continuebutton withContinue anyway.Here's the snapshot:
teamsfx-cli (WSL): deploy function app when .NET SDK is not installed:
Teams Toolkit (WSL): local debug when .NET SDK is not installed: