Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general body scroll fix by CodingYourLife. be aware that it will make… #10435

Closed
wants to merge 3 commits into from

Conversation

codingyourlife
Copy link

… absolutely every page scrollable.

Copy link
Contributor

@azgaresncf azgaresncf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment "fixes e.g..." is not necessarily useful
otherwise, it is very good!

@OhMyGuus
Copy link
Owner

OhMyGuus commented Dec 23, 2023

Not planning on implementing this since it will maybe fix some websites but break a lot of them at the same time.
However maybe it's an idea to add a broken scrollbar button to the report so a bot can automatically create a PR with common 85 (bassicly this css rule)

(Fixed the mentioned websites in my PR as well)

@obfuscated-loop
Copy link
Collaborator

@OhMyGuus That would be a good feature, maybe you could add a <select> within a reporting window so users are able to choose from say 'General issue', 'Scrollbar issue' or 'Modal issue' with a brief description of what each one is after selection. I could make a P.R for this if you'd like.

@OhMyGuus
Copy link
Owner

OhMyGuus commented Dec 23, 2023

@OhMyGuus That would be a good feature, maybe you could add a <select> within a reporting window so users are able to choose from say 'General issue', 'Scrollbar issue' or 'Modal issue' with a brief description of what each one is after selection. I could make a P.R for this if you'd like.

Yeah +1, would really appreciate a pr with that inside👍

@obfuscated-loop
Copy link
Collaborator

obfuscated-loop commented Dec 24, 2023

Yeah +1, would really appreciate a pr with that inside👍

Working on this now - just wondering, with regards to the notes, does your API allow for that to be null? I have gone for hiding the notes textarea when it isn't a 'General issue'. Let me know your thoughts about this. GIF attached.
example

I have also implemented the <select> value as a new parameter in the API request called issueType of which the values could be generalIssue, scrollbarIssue or modalIssue.

@obfuscated-loop
Copy link
Collaborator

obfuscated-loop commented Dec 24, 2023

Actually I realise appending Issue to each value is redundant and they could just be general, scrollbar or modal.

EDIT: I also have yet to add the brief descriptions but I plan on adding that underneath the select box.

@obfuscated-loop
Copy link
Collaborator

@OhMyGuus Merry Christ/Xmas 🎄

Updated GIF attached. Just need to add textarea validation for the general issue.
example

@OhMyGuus
Copy link
Owner

Merry Xmas 🎄
Looks good 👍 and the api is quite flexible will just change it to whatever it requires :)

@codingyourlife
Copy link
Author

I'm not necessarily a fan of the "everything needs to be reported" mentality but with a certain plugin popularity and degree of automation I guess that works out. So whatever gets the job done! I will close this issue now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants