Skip to content

Added consistant function names for BFS and DFS #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Added consistant function names for BFS and DFS #4

merged 1 commit into from
Aug 7, 2017

Conversation

vhag
Copy link
Contributor

@vhag vhag commented Aug 6, 2017

The other search algorithms (Binary Search and Linear Search) search function is simply called search. Breadth First Search (BFS) and Depth First Search (DFS) have the inconsistent names bfs and dfs respectively. I motion that these names are changed in favour of the simpler search.

It will not only make it easier for users (they won't have to look up every single search function's name), but also help easy development.

@Sudo-Kid
Copy link
Contributor

Sudo-Kid commented Aug 6, 2017

I second that. If the user wants to import both BFS and DFS in the same file they can use as in the import. Outside of that the api is better this way.

@vhag vhag mentioned this pull request Aug 6, 2017
@OmkarPathak OmkarPathak merged commit e2318e4 into OmkarPathak:master Aug 7, 2017
OmkarPathak pushed a commit that referenced this pull request Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants