Add BiDirectional AStar #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I switched to using asserts rather than exceptions for things that should be impossible, since exceptions should at least be partly caused by the parameters * docs/Pathfinding.rst - Add BiDirectionalAStar. Functions identically to onedirectional astar, as the differences are solely in performance characteristics * pygorithm/pathfinding/astar.py - Minor documentation tweaks for consistency and improve performance of reversing the list for one directonal astar (avoid shifting elements so much). Fix referencing the loop variable 'i' instead of 'found' and remove related TODO Add BiDirectionalAStar. I think there is some room to reduce the length * tests/test_pathing.py - Add the basic test (passing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched to using asserts rather than exceptions for things that should
be impossible, since exceptions should at least be partly caused by the
parameters
docs/Pathfinding.rst - Add BiDirectionalAStar. Functions identically to
onedirectional astar, as the differences are solely in performance
characteristics
pygorithm/pathfinding/astar.py - Minor documentation tweaks for
consistency and improve performance of reversing the list for one
directonal astar (avoid shifting elements so much). Fix referencing the
loop variable 'i' instead of 'found' and remove related TODO
Add BiDirectionalAStar. I think there is some room to reduce the length