BugFix: content-length is counted in bytes #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and TextWriters. So: Stream-s.
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 65.18% 65.46% +0.28%
==========================================
Files 179 179
Lines 1795 1801 +6
==========================================
+ Hits 1170 1179 +9
+ Misses 625 622 -3
Continue to review full report at Codecov.
|
|
@Lercher merged all the other changes, there are a few minor differences to make here, then we're good to go. 👍 |
|
Did the expected manual merges |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hence we can't use TextReaders and TextWriters in In/OutputHandlers, because otherwise reading chars when there is only a bytes count would be really hard. So I converted everything to streams plus UTF8 Encoding methods plus some test enhancements.
This change is important, because otherwise there is no parsing of text containing non-ASCII characters, which is quite common outside of the US ;-) With it, I can now parse a real Coco/R grammar with a real example :-)
Note: This fix is based on the current OmniSharp/master. As it is some fixes behind, I expect some manual merging.
Martin