Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Korean README translation #383

Merged
merged 11 commits into from
Sep 16, 2022
Merged

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Sep 7, 2022

No description provided.

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2022

Wow!
Thanks, I don't know Korean but It seems several texts are not translated. such as Titles

Would you please take a look again and make sure almost everything possibility has been translated?

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2022

<h2 id="table-of-contents">Table of Contents</h2>
<details open="open">
  <ol>
    <li><a href="#features-of-one">Features of <b>One</b></a></li>
    <li><a href="#roadmap">RoadMap</a></li>
    <li><a href="#code-examples">Code Examples</a></li>
    <li><a href="#getting-started">Getting Started</a></li>
    <li><a href="#get-involved">Get Involved</a></li>
    <li><a href="#license">License</a></li>
  </ol>
</details>


<h2 id="features-of-one">➤ Features of One</h2>

<h2 id="roadmap">➤ RoadMap</h2>

<h2 id="code-examples">➤ Code Examples</h2>

**Convert to C:**


**Another draft:**

**Another draft:**


### Old CLI Development


### Old GUI Development: (Web, Software)


<h2 id="getting-started">➤ Getting Started</h2>


#### Supported Environments

- [x] GNU / Linux <!--which Linux?-->
- [x] Windows
- [ ] macOS (Not complete)
- [ ] BSD

@BaseMax
Copy link
Member

BaseMax commented Sep 7, 2022

# The One Programming Language 💚 💙 🧡 🤍 💖 🖤


### Compiler for the One Language will be released in a few months

langs/READMD_KR.md Outdated Show resolved Hide resolved
langs/READMD_KR.md Outdated Show resolved Hide resolved
@BaseMax
Copy link
Member

BaseMax commented Sep 8, 2022

Thank you for the review.

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some broken links

@BaseMax
Copy link
Member

BaseMax commented Sep 14, 2022

Thanks

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you will need a link for the Korean README in the language links on each README

@jbampton jbampton linked an issue Sep 15, 2022 that may be closed by this pull request
langs/READMD_KR.md Outdated Show resolved Hide resolved
Co-authored-by: John Bampton <jbampton@users.noreply.github.com>
@BaseMax
Copy link
Member

BaseMax commented Sep 16, 2022

Thanks, John please speed up processing this PR.

langs/READMD_KR.md Outdated Show resolved Hide resolved
@jbampton jbampton self-requested a review September 16, 2022 07:51
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The langs folder is now docs.

Could you please update ?

@github-actions github-actions bot added the docs label Sep 16, 2022
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Korean README filename is misspelt

Also you will need a link to the Korean README on the main English README

BaseMax
BaseMax previously approved these changes Sep 16, 2022
Copy link
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Yaminyam
Copy link
Member Author

The Korean README filename is misspelt

Also you will need a link to the Korean README on the main English README

Do I have to set the file name to ko, which kr doesn't want?

@jbampton
Copy link
Member

You have used READMD_KR.md

Should be README_KR.md

Copy link
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix.

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks 💯

@jbampton jbampton merged commit b3f240f into One-Language:main Sep 16, 2022
@BaseMax
Copy link
Member

BaseMax commented Sep 16, 2022

Again thanks @Yaminyam.
You are welcome to add yourself to Next Community. https://github.com/NextCommunity/NextCommunity.github.io#do-you-want-to-add-yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Korean translation
3 participants