Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Marker for Map Searches #33

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Add Marker for Map Searches #33

merged 3 commits into from
Jul 23, 2024

Conversation

hilmyveradin
Copy link
Collaborator

Description

This PR includes changes of changing origin/destination text and add marker when user search location and when user click the "current location"

Test Instructions

  1. Search for a place, click, see if the marker shows up
  2. Try to click on the user location, see if marker shows up

aaronbrethorst
aaronbrethorst approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I note that I cannot use the favorites or recents to set pins on the map yet, but I assume that's next up for you.

@aaronbrethorst aaronbrethorst merged commit 47d9c43 into main Jul 23, 2024
4 checks passed
@aaronbrethorst aaronbrethorst deleted the add-marker-map-searches branch July 23, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilmyveradin @aaronbrethorst