Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qrcode wallet #4626

Merged
merged 11 commits into from
May 27, 2024
Merged

feat: qrcode wallet #4626

merged 11 commits into from
May 27, 2024

Conversation

sidmorizon
Copy link
Contributor

No description provided.

Copy link

codesandbox bot commented May 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

what-the-diff bot commented May 23, 2024

PR Summary

  • New global variable added
    This enhancement broadens the adaptability of the code.
  • Spell checker modification
    Improvement of spell checking through the incorporation of two new words.
  • New package dependencies added
    This change helps to increase the functionality of the code by using external libraries.
  • Changes to QRCode and CoreChainSoftware
    Significant alterations to these sections enhance functionality and efficiency.
  • Addition of 'serviceDemo' service
    This adds new service to the 'BackgroundApi'.
  • New function "createQrWallet"
    Implemented a new function to support QR wallet creation.
  • Enhancements to RealmSchemaWallet and types
    Addition of new properties and types to improve data handling and flexibility.
  • KeyringQr implementation
    Added support for QR code signing which enhances security.
  • Removal of 'demoSend' function
    Code clean up by removing the unused 'demoSend' function.
  • Improved scan capability for QR codes
    Enhanced code to improve QR code scanning functionality and accuracy.
  • Modifications to SendConfirmActionsContainer
    Updates to the transaction confirmation process to increase user-friendliness.
  • Revision of packages/shared/src/consts/dbConsts.ts file
    Adding a new constant for improved categorization of wallet types.
  • Introduction of New Functionality
    Implemented several new features including the ability to normalize path templates and QR wallet ID generation.
  • Package Updates
    Keeping libraries up to date with the latest version for optimal code functioning.
  • Fix Dust Threshold
    Fixed an issue with the dust threshold function for better accuracy.

Copy link

socket-security bot commented May 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@bufbuild/protobuf@1.9.0 environment 0 1.44 MB tstamm-buf
npm/@keystonehq/bc-ur-registry-aptos@0.3.2 environment 0 63.5 kB soralit
npm/@keystonehq/bc-ur-registry-arweave@0.4.0 environment 0 72.2 kB amalia20220301
npm/@keystonehq/bc-ur-registry-btc@0.1.0 environment 0 59.9 kB liyanlance
npm/@keystonehq/bc-ur-registry-cardano@0.3.0 environment 0 103 kB liyanlance
npm/@keystonehq/bc-ur-registry-cosmos@0.2.2 environment 0 61.9 kB soralit
npm/@keystonehq/bc-ur-registry-eth@0.15.2 environment 0 95.3 kB soralit
npm/@keystonehq/bc-ur-registry-evm@0.5.2 environment 0 52.9 kB soralit
npm/@keystonehq/bc-ur-registry-keystone@0.1.0 environment 0 27.4 kB liyanlance
npm/@keystonehq/bc-ur-registry-near@0.8.0 environment 0 53.8 kB amalia20220301
npm/@keystonehq/bc-ur-registry-sol@0.6.2 environment 0 77.2 kB soralit
npm/@keystonehq/bc-ur-registry-sui@0.3.0 environment 0 57.4 kB liyanlance
npm/@keystonehq/bc-ur-registry-ton@0.1.0 environment 0 52.5 kB soralit
npm/@keystonehq/bc-ur-registry@0.5.4 None 0 231 kB soralit
npm/@keystonehq/keystone-sdk@0.4.1 None 0 189 kB soralit
npm/@onekeyhq/qr-wallet-sdk@0.0.0-use.local None 0 0 B
npm/@types/hdkey@2.0.3 None 0 4.3 kB types
npm/hdkey@2.1.0 None 0 15.3 kB ryanzim

🚮 Removed packages: npm/@polkadot/api-augment@10.13.1, npm/@polkadot/api-base@10.13.1, npm/@polkadot/api-derive@10.13.1, npm/@polkadot/rpc-augment@10.13.1, npm/@polkadot/rpc-core@10.13.1, npm/@polkadot/types-known@10.13.1, npm/eventemitter3@5.0.1, npm/fast-deep-equal@3.1.3, npm/fast-json-stable-stringify@2.1.0, npm/html-entities@2.5.2, npm/json-schema-traverse@0.4.1, npm/source-map@0.7.4, npm/uri-js@4.4.1

View full report↗︎

Copy link

socket-security bot commented May 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@sidmorizon sidmorizon marked this pull request as ready for review May 24, 2024 09:22
@sidmorizon sidmorizon enabled auto-merge (squash) May 24, 2024 09:27
@sidmorizon sidmorizon changed the title Feat/qrcode wallet feat: qrcode wallet May 24, 2024
originalix
originalix previously approved these changes May 27, 2024
packages/kit-bg/src/dbs/local/LocalDbBase.ts Show resolved Hide resolved
…-wallet

# Conflicts:
#	packages/core/src/chains/ckb/CoreChainSoftware.ts
#	packages/kit-bg/src/services/ServiceApp.ts
#	packages/kit-bg/src/vaults/impls/ckb/KeyringHd.ts
@sidmorizon sidmorizon merged commit 83b51bc into x May 27, 2024
4 checks passed
@sidmorizon sidmorizon deleted the feat/qrcode-wallet branch May 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants