Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CosineScheduler to CosineAnnealingLR #5112

Merged
merged 29 commits into from
Jun 15, 2021
Merged

Rename CosineScheduler to CosineAnnealingLR #5112

merged 29 commits into from
Jun 15, 2021

Conversation

duchengyao
Copy link
Contributor

@duchengyao duchengyao commented Jun 7, 2021 •
edited
Loading

image

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@duchengyao duchengyao changed the title Request to integrate new scheduler: CosineAnnealingLR [WIP] Request to integrate new scheduler: CosineAnnealingLR Jun 7, 2021
@duchengyao duchengyao force-pushed the cosine_annealing_lr branch from aa069a1 to c5c9ac9 Compare June 7, 2021 03:07
@duchengyao duchengyao mentioned this pull request Jun 7, 2021
Closed
@duchengyao
Copy link
Contributor Author

与 oneflow 对齐 tf.keras 的 CosineScheduler 出自同一篇论文SGDR: Stochastic Gradient Descent with Warm Restarts，关闭PR

@duchengyao duchengyao closed this Jun 7, 2021
@wyg1997
Copy link
Contributor

wyg1997 commented Jun 11, 2021

这个PR把之前的 CosineScheduler 改成Pytorch的命名吧，不用重新写了。我们eager模式还是对齐Pytorch的接口，以后会逐步把lazy的风格也迁移过来。

@duchengyao
Copy link
Contributor Author

这个PR把之前的 CosineScheduler 改成Pytorch的命名吧，不用重新写了。我们eager模式还是对齐Pytorch的接口，以后会逐步把lazy的风格也迁移过来。

好的，我来做

@duchengyao duchengyao reopened this Jun 11, 2021
@duchengyao duchengyao force-pushed the cosine_annealing_lr branch from c5c9ac9 to 6ec533c Compare June 11, 2021 04:23
@duchengyao duchengyao requested a review from wyg1997 June 11, 2021 04:25
@duchengyao duchengyao changed the title [WIP] Request to integrate new scheduler: CosineAnnealingLR Request to integrate new scheduler: CosineAnnealingLR Jun 11, 2021
@wyg1997
Copy link
Contributor

wyg1997 commented Jun 11, 2021

这个Scheduler的文件名也需要改一下

@duchengyao
Copy link
Contributor Author

这个Scheduler的文件名也需要改一下

Resolved

@duchengyao duchengyao changed the title Request to integrate new scheduler: CosineAnnealingLR Rename CosineSheduler to CosineAnnealingLR Jun 11, 2021
wyg1997
wyg1997 reviewed Jun 11, 2021
View reviewed changes
Copy link
Contributor

@wyg1997 wyg1997 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦对，还有一点，在公式下面把论文的链接贴上吧

@wyg1997 wyg1997 self-requested a review June 15, 2021 01:53
@JiaojiaoYe1994 JiaojiaoYe1994 mentioned this pull request Jun 15, 2021
Closed
@duchengyao duchengyao changed the title Rename CosineSheduler to CosineAnnealingLR Rename CosineScheduler to CosineAnnealingLR Jun 15, 2021
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 15, 2021 16:14
@oneflow-ci-bot oneflow-ci-bot removed their request for review June 15, 2021 17:42
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 15, 2021 17:42
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 15, 2021 18:48
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 15, 2021 20:33
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 15, 2021 21:34
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot June 15, 2021 22:15
@oneflow-ci-bot oneflow-ci-bot merged commit 5e4365f into master Jun 15, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the cosine_annealing_lr branch June 15, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyg1997 wyg1997 wyg1997 approved these changes

Assignees
No one assigned
Labels
automerge documentation eager interface python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@duchengyao @CLAassistant @wyg1997 @jackalcooper @oneflow-ci-bot