Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor infer ctx input tensordesc #5226

Merged
merged 46 commits into from
Jul 9, 2021
Merged

Refactor infer ctx input tensordesc #5226

merged 46 commits into from
Jul 9, 2021

Conversation

luqiang-guo
Copy link
Contributor

Use InputTensorDesc function instead of TensorDesc4ArgNameAndIndex function.

@luqiang-guo
Refactor infer ctx input tensordesc and related calls
125a609
@luqiang-guo
Modify the missing content
66002fa
@luqiang-guo
Merge branch 'master' into dev_refactor_infer_ctx_input_tensordesc
ed12fcc 
# Conflicts:
#	oneflow/user/ops/combined_margin_loss_op.cpp
#	oneflow/user/ops/ctc_loss_op.cpp
#	oneflow/user/ops/fused_bias_add_op.cpp
#	oneflow/user/ops/fused_scale_tril_softmax_mask_scale_op.cpp
#	oneflow/user/ops/image_object_preprocess_ops.cpp
#	oneflow/user/ops/l1_l2_regularize_gradient_op.cpp
#	oneflow/user/ops/math_binary_broadcast_ops.cpp
#	oneflow/user/ops/prelu_op.cpp
#	oneflow/user/ops/softmax_cross_entropy_op.cpp
#	oneflow/user/ops/sparse_cross_entropy_op.cpp
#	oneflow/user/ops/sparse_softmax_cross_entropy_op.cpp
#	oneflow/user/ops/unsorted_segment_sum_op.cpp
@luqiang-guo luqiang-guo requested a review from ouyangyu June 17, 2021 08:59
@luqiang-guo luqiang-guo requested review from liufengwei0103 and removed request for ouyangyu June 17, 2021 10:08
liufengwei0103
liufengwei0103 reviewed Jun 17, 2021
View reviewed changes
oneflow/user/kernels/stateful_local_opkernel.h Outdated
@@ -23,6 +23,7 @@ limitations under the License.
#include "oneflow/core/framework/user_op_kernel_registry.h"
#include "oneflow/core/framework/arg_tuple.h"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一行空白

liufengwei0103
liufengwei0103 reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@liufengwei0103 liufengwei0103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.有一些op里漏了，比如：layer_norm_op.cpp:274
2.kernel文件中，调用TensorDesc4ArgNameAndIndex的位置也需要读写分离

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 5, 2021 10:03
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 5, 2021 11:04
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 5, 2021 12:33
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 04:54
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 06:41
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 9, 2021 08:54
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 10:55
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 12:35
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 13:41
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 15:02
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 16:14
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 9, 2021 17:15
@oneflow-ci-bot oneflow-ci-bot merged commit 3abfe71 into master Jul 9, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_refactor_infer_ctx_input_tensordesc branch July 9, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengwei0103 liufengwei0103 liufengwei0103 approved these changes

Assignees
No one assigned
Labels
automerge enhancement system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luqiang-guo @liufengwei0103 @jackalcooper @oneflow-ci-bot