Add test for convtranspose2d #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldpe2G
reviewed
Jun 18, 2021
oneflow/python/nn/modules/deconv.py
Outdated
| self.weight = flow.nn.Parameter( | ||
| flow.Tensor(in_channels, out_channels // groups, *kernel_size) | ||
| flow.Tensor(out_channels // groups, in_channels, *kernel_size) |
There was a problem hiding this comment.
flow.Tensor(in_channels, out_channels // groups, *kernel_size) 应该是这样
Ldpe2G
reviewed
Jun 18, 2021
oneflow/python/nn/modules/deconv.py
Outdated
| out_list = [] | ||
| for i in range(len(in_split_list)): | ||
| out_list.append( | ||
| self._op(in_split_list[i], self.weight[:, i : i + 1, :, :])[0] |
There was a problem hiding this comment.
这里 weight 取错了？应该是 self.weight[i * groups : (i+1) * groups, :, :, :])[0]
There was a problem hiding this comment.
这个地方应该是是没有取错的，上面权重的shape已经是flow.Tensor(in_channels, out_channels // groups, *kernel_size)，相当于这个通道已经除了groups了。
Ldpe2G
reviewed
Jun 18, 2021
Ldpe2G
reviewed
Jun 19, 2021
oneflow/python/nn/modules/deconv.py
Outdated
| out_list = [] | ||
| for i in range(len(in_split_list)): | ||
| out_list.append( | ||
| self._op(in_split_list[i], self.weight[i : (i + 1), :, :, :])[0] |
There was a problem hiding this comment.
这里还是有问题，你测试用例里面 输入通道没有大于2的，测不出来问题
…flow-Inc/oneflow into add_test_for_convtranspose2d
Ldpe2G
approved these changes
Jun 19, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现group convtranspose2d功能。