Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clip_grad_norm #5299

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Add clip_grad_norm #5299

merged 6 commits into from
Jul 28, 2021

Conversation

zjlablichenyang
Copy link
Contributor

@zjlablichenyang zjlablichenyang commented Jun 24, 2021

clip_grad_norm_ docstring
clip_grad_norm

clip_grad_norm_ doctest
clip_grad_norm_test1
clip_grad_norm_test2

@zjlablichenyang zjlablichenyang marked this pull request as ready for review July 19, 2021 07:10
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 19, 2021 07:11
@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 19, 2021 07:17
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 19, 2021 08:27
@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 19, 2021 08:47
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 19, 2021 10:29
@zjlablichenyang zjlablichenyang requested review from wyg1997 and oneflow-ci-bot and removed request for doombeaker July 20, 2021 01:26
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 20, 2021 02:28
oneflow/python/nn/utils/clip_grad.py Outdated Show resolved Hide resolved
oneflow/python/nn/utils/clip_grad.py Outdated Show resolved Hide resolved
oneflow/python/nn/utils/clip_grad.py Outdated Show resolved Hide resolved
@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 20, 2021 07:18
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 20, 2021 11:51
@oneflow-ci-bot oneflow-ci-bot self-requested a review July 28, 2021 01:28
@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 28, 2021 01:32
@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 28, 2021 01:54
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 28, 2021 02:09
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@zjlablichenyang zjlablichenyang requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 28, 2021 03:05
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 28, 2021 04:23
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 28, 2021 04:30
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.6ms (= 7028.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.3ms (= 6313.9ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 140.6ms / 126.3ms)

PyTorch resnet50 time: 84.9ms (= 4243.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 73.7ms (= 3683.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.15 (= 84.9ms / 73.7ms)

PyTorch resnet50 time: 63.9ms (= 3193.3ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 48.1ms (= 2405.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.33 (= 63.9ms / 48.1ms)

PyTorch resnet50 time: 49.8ms (= 2492.4ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 43.7ms (= 2182.5ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.14 (= 49.8ms / 43.7ms)

PyTorch resnet50 time: 44.9ms (= 2246.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 41.3ms (= 2067.3ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 44.9ms / 41.3ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 28bb85e into master Jul 28, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the lcy_clipgrad branch July 28, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants