refine pow module and its test #5319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VertexC
reviewed
Jun 27, 2021
doombeaker
reviewed
Jun 29, 2021
| @@ -1013,8 +1013,18 @@ def forward(self, x, y): | |||
| @experimental_api | |||
| def pow_op(tensor, exponent): | |||
| r"""Takes the power of each element in input with exponent and returns a tensor with the result. | |||
| exponent can be either a single float number or a single int number. | |||
|
|
|||
| exponent can be either a single float number, a single int number, or a tensor with the same shape as input. | |||
There was a problem hiding this comment.
需要在 PR 的 description 里附上 docstring 编译后的截图（顺便也检查了编译文档时有否warning，现在文档编译有warning也是不能通过CI测试的）
There was a problem hiding this comment.
呃……还是不符合要求。你可以参考下已经合并的PR，比如这个 #5101
doombeaker
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctest:
docstring: