support bias in conv2d's parameter list #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
debug发现导致带bias的卷积segment fault的原因是bias初始化的内存位置不对，尝试将值写到一块不能写的内存（已经被im2col写过了）所以segmentfault |
mosout
changed the title
BBuf
reviewed
Jun 29, 2021
| for arg in GenArgList(arg_dict): | ||
| compare_with_tensorflow(*arg) | ||
|
|
||
| def test_cpu2(test_case): |
There was a problem hiding this comment.
命名是否可以具体一点，比如groups和channels相等就是depthwise，以及这个测试样例感觉可以测一下多卡
There was a problem hiding this comment.
这个是从test_conv2d里拷过来的 我改一下
BBuf
approved these changes
Jun 29, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
mosout
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使卷积算子支持bias作为参数