MultiClientSession #5407
Merged
MultiClientSession #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strint
reviewed
Jul 9, 2021
strint
reviewed
Jul 9, 2021
strint
reviewed
Jul 9, 2021
strint
reviewed
Jul 9, 2021
strint
reviewed
Jul 9, 2021
|
这个等 MultiClientSessionContext 合并以后就合吧 |
chengtbf
approved these changes
Jul 10, 2021
chengtbf
reviewed
Jul 11, 2021
|
|
||
| def TryInit(self): | ||
| if not self.is_inited_: | ||
| config_proto_str = text_format.MessageToString(self.config_proto) |
There was a problem hiding this comment.
应该加一个 MultiClientSession 下的单测，尝试去 TryInit，这里的 config_proto，由于其中的 Resource 里有多个 require 的字段，但是没有设置，导致 C++ 里想把这个 str 解析成 proto 时报错。
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.