Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add torchstyle unittest #5489

Merged
merged 15 commits into from
Jul 15, 2021
Merged

add torchstyle unittest #5489

merged 15 commits into from
Jul 15, 2021

Conversation

MARD1NO
Copy link
Contributor

@MARD1NO MARD1NO commented Jul 14, 2021 •
edited
Loading

记录问题

  1. softmax行为和torch不一致，torch不允许不指定dim（但是前向正常运行，后向失败，抛出UserWarning）。我们的softmax如果不指定dim，则设置为-1。 影响的Module有Softmax，LogSoftmax
  2. Softplus在torch1.8.1版本暂时有bug，跳过测试
  3. Hardtanh，pytorch引入了两个无用的参数min_value, max_value，跳过
  4. torch1.8.1暂时还没有Mish Module
  • oneflow.experimental.nn.GELU
  • oneflow.experimental.gelu torch没有这个方法
  • oneflow.experimental.Tensor.gelu torch没有这个方法
  • oneflow.experimental.nn.Sigmoid
  • oneflow.experimental.sigmoid
  • oneflow.experimental.Tensor.sigmoid
  • oneflow.experimental.nn.Hardsigmoid
  • oneflow.experimental.softmax 没有完全对齐
  • oneflow.experimental.Tensor.softmax 没有完全对齐
  • oneflow.experimental.nn.LogSigmoid
  • oneflow.experimental.nn.Softplus torch有bug
  • oneflow.experimental.nn.LogSoftmax 没有完全对齐
  • oneflow.experimental.nn.Mish torch1.8.1没有该module
  • oneflow.experimental.mish torch没有这个方法
  • oneflow.experimental.Tensor.mish torch没有这个方法
  • oneflow.experimental.acosh
  • oneflow.experimental.Tensor.acosh
  • oneflow.experimental.arccosh
  • oneflow.experimental.Tensor.arccosh

 

@MARD1NO MARD1NO requested a review from BBuf July 15, 2021 02:39
@MARD1NO MARD1NO marked this pull request as ready for review July 15, 2021 02:39
BBuf
BBuf reviewed Jul 15, 2021
View reviewed changes
oneflow/python/test/modules/test_arccosh.py Outdated
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把这些数学函数移到math_ops.py里面去吧，然后把这些文件删了

@BBuf BBuf added the automerge label Jul 15, 2021
@BBuf BBuf requested a review from oneflow-ci-bot July 15, 2021 06:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 15, 2021 06:28
@oneflow-ci-bot oneflow-ci-bot merged commit fd11384 into master Jul 15, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the add_torch_unittest_zzk branch July 15, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBuf BBuf BBuf approved these changes

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge enhancement feature python test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MARD1NO @BBuf @oneflow-ci-bot